From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ajay Bhargav <ajay.bhargav@einfochips.com>
Date: Wed, 17 Aug 2011 14:18:16 +0530 (IST)
Subject: [U-Boot] [PATCH v6 1/2] gpio: Add GPIO driver framework for
	Marvell SoCs
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19FE5D25D0@SC-VEXCH4.marvell.com>
Message-ID: <972251876.97297.1313570896449.JavaMail.root@ahm.einfochips.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:

> Hi Ajay
> I am sorry if I missed this in my earlier reviews.
> 
> Why you wish to keep mvgpio.h in /include folder?
> I think it should be in drivers/gpio/.
> 
> Regards..
> Prafulla . .
> 

Hi Prafulla,

gpio.h includes this file, as GPIO_LEVEL_SET/CLR are defined
in mvgpio.h which may be needed by other files accessing gpios.
In my case I am using gpio for PHY reset. I was thinking not to
keep any magic number 1/0 for set/clr gpio pin.

Regards,
Ajay Bhargav