From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F778C12002 for ; Wed, 21 Jul 2021 17:02:21 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B63F361222 for ; Wed, 21 Jul 2021 17:02:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B63F361222 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5246980223; Wed, 21 Jul 2021 19:02:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VJEkD8lJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E351880612; Wed, 21 Jul 2021 19:02:16 +0200 (CEST) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7DA6380214 for ; Wed, 21 Jul 2021 19:02:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x82e.google.com with SMTP id k9so2359118qtx.3 for ; Wed, 21 Jul 2021 10:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Kj9dzVGNons/fXym5FSNVdaWFTNBuCsG3Wzm+NzZwxY=; b=VJEkD8lJOxsCtYbOGb5oq8B7a0Rbl/AmWXdiFZ6odNIexnwvY+3/DXHr3bjjO9olBT ahQmcrP5qIapSMkHjyfb0qKDW6YGBsHVidBd0uZU83B1XQGseZ9jfwnV5V7c8Y4jL4Zo lg9JsYd3BT4nrWjglMhRwUMfjocseUxJDCkMK6+Gj/CriicRpHf+ODuBEZpypjh2IRHW rgDnHk8bvli05QzaGBQmD/C3t/m5kfaLm0Zc2pobR52A6LekpoeKRuxaQxKP84E4Yan5 CDbZAjdy8Cu5Pm0sigNP+nF4oqatbDQi3wU65EObC35j/Ka10VsKll0FjS9y56GzJAnF CfrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Kj9dzVGNons/fXym5FSNVdaWFTNBuCsG3Wzm+NzZwxY=; b=hXO5LEcAmFHN1Pk88MEdFoRah+685hfkpycURcq+YCN8BYQWSqqnl5pTWi4YOtpNLv SntkkHTmJfbZgjXBt0gyjJhUGNEtrNXhGdSgyR354pBr9FD27arEo16e4pUDGS/l0gbe 6eBXxixwE1ca7tObPaNkmwVjC/JP+DuqnDPGIN3Alg+1h3rv2vNYaqRz7sGsASvJ0AcQ 4Bc2Q0ehOnyfLd2v2Kgd18K6+1a1mCZhw5tw+VGOftZU4XtrbuoCc2lTyAIdHaY2JZL5 gk9GWlJE/jGI+STdC8KM/pZyKp0PeWgrlXCEI6TY02+nbX+pahdeLNqzG9xheYhsVfmP EzCw== X-Gm-Message-State: AOAM531d/3t4GnB/Wb5k+sT5UXSbTTdIJOMrEJj1/A4YM6v9RYaAxUN5 6MpVE5mLqhGl0xjqW27wn/rz69sW9II= X-Google-Smtp-Source: ABdhPJwp00GNjG017T429XLv4I3DMJZt93flLjr+divAZ0rcML18fyKe6dKd9bhTrbfWaTRhyzfmdA== X-Received: by 2002:ac8:73cc:: with SMTP id v12mr23231238qtp.391.1626886931815; Wed, 21 Jul 2021 10:02:11 -0700 (PDT) Received: from [192.168.1.201] (pool-74-96-87-9.washdc.fios.verizon.net. [74.96.87.9]) by smtp.googlemail.com with ESMTPSA id m23sm9117217qtq.53.2021.07.21.10.02.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jul 2021 10:02:11 -0700 (PDT) Subject: Re: [PATCH v2 1/3] risv: add missing SBI extension definitions To: Heinrich Schuchardt , Rick Chen Cc: Leo , Alexander Graf , Bin Meng , Green Wan , =?UTF-8?Q?Marek_Beh=c3=ban?= , Pragnesh Patel , Atish Patra , Ley Foon Tan , Chee Hong Ang , Simon Glass , Siew Chin Lim , Sebastian Reichel , u-boot@lists.denx.de References: <20210721163305.74945-1-xypron.glpk@gmx.de> <20210721163305.74945-2-xypron.glpk@gmx.de> From: Sean Anderson Message-ID: <985b44a4-7634-245c-70eb-aba1ae541a2e@gmail.com> Date: Wed, 21 Jul 2021 13:02:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210721163305.74945-2-xypron.glpk@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 7/21/21 12:33 PM, Heinrich Schuchardt wrote: > Add the System Reset Extension and the Hart State Management Extension > definitions. > > Add missing RFENCE Extension enum values. > > The SBI 0.1 extension constants are needed for for the sbi command. Remove > an #ifdef. > > Cf. https://github.com/riscv/riscv-sbi-doc/blob/master/riscv-sbi.adoc > > Signed-off-by: Heinrich Schuchardt > --- > v2: > correct constants that were blindly copied from Linux > --- > arch/riscv/include/asm/sbi.h | 36 ++++++++++++++++++++++++++++++++++-- > 1 file changed, 34 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/include/asm/sbi.h b/arch/riscv/include/asm/sbi.h > index 53ca316180..39d5a022e0 100644 > --- a/arch/riscv/include/asm/sbi.h > +++ b/arch/riscv/include/asm/sbi.h > @@ -12,7 +12,6 @@ > #include > > enum sbi_ext_id { > -#ifdef CONFIG_SBI_V01 > SBI_EXT_0_1_SET_TIMER = 0x0, > SBI_EXT_0_1_CONSOLE_PUTCHAR = 0x1, > SBI_EXT_0_1_CONSOLE_GETCHAR = 0x2, > @@ -22,11 +21,12 @@ enum sbi_ext_id { > SBI_EXT_0_1_REMOTE_SFENCE_VMA = 0x6, > SBI_EXT_0_1_REMOTE_SFENCE_VMA_ASID = 0x7, > SBI_EXT_0_1_SHUTDOWN = 0x8, > -#endif > SBI_EXT_BASE = 0x10, > SBI_EXT_TIME = 0x54494D45, > SBI_EXT_IPI = 0x735049, > SBI_EXT_RFENCE = 0x52464E43, > + SBI_EXT_HSM = 0x48534D, > + SBI_EXT_SRST = 0x53525354, > }; > > enum sbi_ext_base_fid { > @@ -51,6 +51,38 @@ enum sbi_ext_rfence_fid { > SBI_EXT_RFENCE_REMOTE_FENCE_I = 0, > SBI_EXT_RFENCE_REMOTE_SFENCE_VMA, > SBI_EXT_RFENCE_REMOTE_SFENCE_VMA_ASID, > + SBI_EXT_RFENCE_REMOTE_HFENCE_GVMA_VMID, > + SBI_EXT_RFENCE_REMOTE_HFENCE_GVMA, > + SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA_ASID, > + SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA, > +}; > + > +enum sbi_ext_hsm_fid { > + SBI_EXT_HSM_HART_START = 0, > + SBI_EXT_HSM_HART_STOP, > + SBI_EXT_HSM_HART_STATUS, > +}; > + > +enum sbi_hsm_hart_status { > + SBI_HSM_HART_STATUS_STARTED = 0, > + SBI_HSM_HART_STATUS_STOPPED, > + SBI_HSM_HART_STATUS_START_PENDING, > + SBI_HSM_HART_STATUS_STOP_PENDING, Perhaps add the suspend states from https://github.com/riscv/riscv-sbi-doc/pull/66 > +}; > + > +enum sbi_ext_srst_fid { > + SBI_EXT_SRST_RESET = 0, > +}; > + > +enum sbi_srst_reset_type { > + SBI_SRST_RESET_TYPE_SHUTDOWN = 0, > + SBI_SRST_RESET_TYPE_COLD_REBOOT, > + SBI_SRST_RESET_TYPE_WARM_REBOOT, > +}; > + > +enum sbi_srst_reset_reason { > + SBI_SRST_RESET_REASON_NONE = 0, > + SBI_SRST_RESET_REASON_SYS_FAILURE, > }; > > #ifdef CONFIG_SBI_V01 > -- > 2.30.2 > Reviewed-by: Sean Anderson