Re: [PATCH] odroid: add CROS_EC to odroid_defconfig

[Joost van Zwieten <joost@diskos.nl>]

On Mon, Jan 23, 2023 at 08:33, Peter Robinson <pbrobinson@gmail.com> 
wrote:
> On Fri, Jan 20, 2023 at 11:17 PM Joost van Zwieten <joost@diskos.nl> 
> wrote:
>> 
>>  As of commit e44d7e73fe ("dm: core: Switch uclass_*_device_err to 
>> use
>>  uclass_*_device_check") U-Boot built with `odroid_defconfig` fails 
>> to
>>  initialize on an Odroid U2: `board_late_init()`
>>  (board/samsung/common/board.c)
>>  returns with an error due to the absence of the CROS_EC uclass, and 
>> the
>>  board
>>  resets. This patch adds `CROS_EC` to the defconfig, leading to a
>>  succcessful
>>  initialization of U-Boot.
> 
> This doesn't seem to be the right fix to the problem, why would an
> odroid device have a need for a driver for the ChromeOS Embedded
> Controller?

For reference, here's the thread that led to this patch: [1].

My board returns `ENODEV` when calling
`uclass_first_device_err(UCLASS_CROS_EC, &dev)` with `CROS_EC` enabled,
so I don't seem to have this device.

At the end of [1] I have suggested an alternative fix: enclosing a
couple of statements that assume there's a CROS_EC driver inside an
`#ifdef CONFIG_CROS_EC`. Do you think that is a viable approach? I'm not
at all familiar with the U-Boot codebase, so forgive me if this doesn't
make any sense.

[1]: https://lists.denx.de/pipermail/u-boot/2023-January/505627.html

> 
>>  Signed-off-by: Joost van Zwieten <joost@diskos.nl>
>>  ---
>>   configs/odroid_defconfig | 1 +
>>   1 file changed, 1 insertion(+)
>> 
>>  diff --git a/configs/odroid_defconfig b/configs/odroid_defconfig
>>  index 6e1c29b355..b1ccabd0d2 100644
>>  --- a/configs/odroid_defconfig
>>  +++ b/configs/odroid_defconfig
>>  @@ -55,6 +55,7 @@ CONFIG_DFU_MMC=y
>>   CONFIG_SET_DFU_ALT_INFO=y
>>   CONFIG_SYS_DFU_DATA_BUF_SIZE=0x2000000
>>   CONFIG_SYS_I2C_S3C24X0=y
>>  +CONFIG_CROS_EC=y
>>   CONFIG_MMC_DW=y
>>   CONFIG_MMC_SDHCI=y
>>   CONFIG_MMC_SDHCI_SDMA=y
>>  --
>>  2.30.2
>> 
>> 
>> 
>> 
>>