From: Michael Walle <michael@walle.cc>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] cmd: fru: Add support for FRU commands
Date: Tue, 22 Oct 2019 15:09:31 +0200 [thread overview]
Message-ID: <9a76a6b9c73025ee253e2afb98f89236@walle.cc> (raw)
In-Reply-To: <299fbc3c72c46ceb1b03fb2843876ff3e2f255ca.1571059750.git.michal.simek@xilinx.com>
Am 2019-10-14 15:29, schrieb Michal Simek:
> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
>
> This patch adds support for fru commands "fru capture" and "fru
> display".
> The fru capture parses the FRU table present at an address and stores
> in a
> structure for later use. The fru display prints the content of captured
> structured in a readable format.
>
> As of now, it supports only common header and board area of FRU. Also,
> it
> supports only English language code and ASCII8 format.
>
> fru_data variable is placed to data section because fru parser can be
> called very early before bss is initialized. And also information needs
> to
> be shared that's why it is exported via header.
Wouldn't it make more sense to have a level of indirection so other
"fru" formats might be supported as well. As far as I can see, only
"your" type of FRU data is supported by this command and there is now
way to extend it.
Also why do the user have to manually do a "fru capture"? The use case
is to display any FRU data, correct? So from a users perspective a "fru
display" be sufficient to display the data.
-michael
next prev parent reply other threads:[~2019-10-22 13:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 13:29 [U-Boot] [PATCH 0/3] cmd: fru: Add simple FRU generator and parser Michal Simek
2019-10-14 13:29 ` [U-Boot] [PATCH 1/3] cmd: fru: Add support for FRU commands Michal Simek
2019-10-21 23:46 ` Simon Glass
2019-10-22 12:57 ` Michal Simek
2019-10-22 12:40 ` Jean-Jacques Hiblot
2019-10-22 12:54 ` Michal Simek
2019-10-22 13:09 ` Michael Walle [this message]
2019-10-22 13:45 ` Michal Simek
2019-10-22 14:43 ` Michael Walle
2019-10-23 7:11 ` Michal Simek
2019-10-14 13:29 ` [U-Boot] [PATCH 2/3] cmd: fru: Add basic fru format generator Michal Simek
2019-10-14 13:29 ` [U-Boot] [PATCH 3/3] arm64: versal: Enable FRU command Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a76a6b9c73025ee253e2afb98f89236@walle.cc \
--to=michael@walle.cc \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox