Re: [PATCH 1/5] acpi: new function acpi_update_checksum()

[Matthias Brugger <mbrugger@suse.com>]

On 22/03/2025 00:21, Heinrich Schuchardt wrote:
> Introduce a new function to update ACPI table headers.
> This allows to simplify the existing code.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Reviewed-by: Matthias Brugger <mbrugger@suse.com>

> ---
>   include/acpi/acpi_table.h | 7 +++++++
>   lib/acpi/acpi.c           | 7 +++++++
>   2 files changed, 14 insertions(+)
> 
> diff --git a/include/acpi/acpi_table.h b/include/acpi/acpi_table.h
> index b8b1f1338c6..f8e5f552ab1 100644
> --- a/include/acpi/acpi_table.h
> +++ b/include/acpi/acpi_table.h
> @@ -1274,6 +1274,13 @@ ulong write_acpi_tables(ulong start);
>    */
>   struct acpi_table_header *acpi_find_table(const char *sig);
>   
> +/**
> + * acpi_update_checksum() - update ACPI table checksum
> + *
> + * @header - header of an ACPI table
> + */
> +void acpi_update_checksum(struct acpi_table_header *header);
> +
>   #endif /* !__ACPI__*/
>   
>   #include <asm/acpi_table.h>
> diff --git a/lib/acpi/acpi.c b/lib/acpi/acpi.c
> index f4d5c1e25d0..596301a43fe 100644
> --- a/lib/acpi/acpi.c
> +++ b/lib/acpi/acpi.c
> @@ -6,11 +6,18 @@
>    */
>   
>   #include <mapmem.h>
> +#include <tables_csum.h>
>   #include <acpi/acpi_table.h>
>   #include <asm/global_data.h>
>   
>   DECLARE_GLOBAL_DATA_PTR;
>   
> +void acpi_update_checksum(struct acpi_table_header *header)
> +{
> +	header->checksum = 0;
> +	header->checksum = table_compute_checksum(header, header->length);
> +}
> +
>   struct acpi_table_header *acpi_find_table(const char *sig)
>   {
>   	struct acpi_rsdp *rsdp;