From: Quentin Schulz <quentin.schulz@cherry.de>
To: Leonard Anderweit <l.anderweit@phytec.de>, u-boot@lists.denx.de
Cc: trini@konsulko.com, sjg@chromium.org, upstream@lists.phytec.de
Subject: Re: [PATCH] doc: build: docker: Fix code-block formatting
Date: Tue, 1 Apr 2025 12:07:31 +0200 [thread overview]
Message-ID: <9b5a0cd4-9e6b-43c5-a770-5fc1e90e82bc@cherry.de> (raw)
In-Reply-To: <20250401094952.8896-1-l.anderweit@phytec.de>
Hi Leonard,
On 4/1/25 11:49 AM, Leonard Anderweit wrote:
> Remove double : before code-block. While at it, use code-block for all
Why?
https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#literal-blocks
is valid.
We could think about changing the default highlighting language to bash
maybe, I don't know.
If you use ..code-block instead of :: for syntax highlighting, then say
that in the commit log :)
Can be two commits though, one for fixing the :: following by a
..code-block, and another one for switching the :: to ..code-block::
with syntax highlighting.
> bash commands.
>
> Signed-off-by: Leonard Anderweit <l.anderweit@phytec.de>
> ---
> doc/build/docker.rst | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/doc/build/docker.rst b/doc/build/docker.rst
> index 01ed35050908..4974a98d4af5 100644
> --- a/doc/build/docker.rst
> +++ b/doc/build/docker.rst
> @@ -12,7 +12,9 @@ You will need a multi-platform container, otherwise this error is shown::
> ERROR: Multi-platform build is not supported for the docker driver.
> Switch to a different driver, or turn on the containerd image store, and try again.
>
> -You can add a simple one with::
> +You can add a simple one with:
> +
> +.. code-block:: bash
>
> sudo docker buildx create --name multiarch --driver docker-container --use
>
> @@ -20,7 +22,9 @@ This will result in a builder that will use QEMU for the non-native
> architectures request in a build. While both amd64 and arm64 happen in
> parallel, the non-native part will take considerably longer as it must use QEMU
> to emulate the foreign code. An alternative, if you have accesss to reasonably
> -fast amd64 (i.e. 64-bit x86) and arm64 machines is::
> +fast amd64 (i.e. 64-bit x86) and arm64 machines is:
> +
> +.. code-block:: bash
>
> sudo docker buildx create --name multiarch-multinode --node localNode --bootstrap --use
> sudo docker buildx create --name multiarch-multinode --append --node remoteNode --bootstrap ssh://user@host
> @@ -28,7 +32,7 @@ fast amd64 (i.e. 64-bit x86) and arm64 machines is::
> And this will result in a builder named multiarch-multinode that will build
> each platform natively on each node.
>
> -To build the image yourself::
> +To build the image yourself:
This one change is fine though (or removing the next line).
>
> .. code-block:: bash
>
Cheers,
Quentin
next prev parent reply other threads:[~2025-04-01 10:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 9:49 [PATCH] doc: build: docker: Fix code-block formatting Leonard Anderweit
2025-04-01 10:07 ` Quentin Schulz [this message]
2025-04-01 11:18 ` Leonard Anderweit
2025-04-01 13:53 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b5a0cd4-9e6b-43c5-a770-5fc1e90e82bc@cherry.de \
--to=quentin.schulz@cherry.de \
--cc=l.anderweit@phytec.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=upstream@lists.phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox