public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rupjyoti Sarmah <rsarmah@apm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2]ppc4xx/Canyonlands added USB board callbacks
Date: Wed, 7 Jul 2010 18:05:16 +0530	[thread overview]
Message-ID: <9c2f009e51e31ec36c5bd81e595a9980@mail.gmail.com> (raw)
In-Reply-To: <201007071305.11262.sr@denx.de>

Hi Stefan and Felix,

Thanks for your inputs. I am releasing v3 with the updates.

Regards,
Rup



-----Original Message-----
From: Stefan Roese [mailto:sr at denx.de]

> isolates USB manipulations such that it is only touched if USB is
> used by U-Boot.

Thanks. Looks quite good now. Please find a small comment below.

<snip>

> diff --git a/include/configs/canyonlands.h
b/include/configs/canyonlands.h
> index ac9b3c5..0eee522 100644
> --- a/include/configs/canyonlands.h
> +#define CONFIG_SYS_BCSR3_PCIE	0x10
> +

Hmmm. Which of these defines are really bits and which are offsets for
registers? You can remove the register offsets defines, since you're using
the
struct now. And please use consistent naming, and don't name one bit
"CONFIG_SYS_BCSRxxx".

  reply	other threads:[~2010-07-07 12:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-07 10:49 [U-Boot] [PATCH v2]ppc4xx/Canyonlands added USB board callbacks Rupjyoti Sarmah
2010-07-07 11:05 ` Stefan Roese
2010-07-07 12:35   ` Rupjyoti Sarmah [this message]
2010-07-07 11:13 ` Felix Radensky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c2f009e51e31ec36c5bd81e595a9980@mail.gmail.com \
    --to=rsarmah@apm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox