From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E8E5C433EF for ; Sat, 18 Jun 2022 12:24:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 757BF842FA; Sat, 18 Jun 2022 14:24:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Gi6O+MA4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3AC3D84434; Sat, 18 Jun 2022 14:24:21 +0200 (CEST) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C4228842D4 for ; Sat, 18 Jun 2022 14:24:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-wr1-x433.google.com with SMTP id w17so8767626wrg.7 for ; Sat, 18 Jun 2022 05:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=uozrw6RGE7WXQ8lAo+b3R158z6Z0HSfakkNDktIK99E=; b=Gi6O+MA4zA1Zi4WFxinrGA5r66T6fOVXZeU2B0mw958fMuszcHQxcF6clOmfQcUsNS j1RVChGZJPWKFh7iEws7DWbtC+PH8Bo6CwxlaIoiTXC1ckKrOGzSiKCiPmzfH5JyuSVq fivsB9qDrjb/TiwenA37SKVB5MEuQtCIFUgkWcWWBs7r4KgtLWesOW/UWRACJdgEHSr3 sdzYn6yDthZOiZH0xYhSypHpwyhg6P9gCEn6URFoqQPiVKNO/thHkpJLiElBrM0uXI1n +Zd12W5O8wAsjV+GP3W8VNPcnelKkz8i8LmYORhhjXDAB66K0oXhSheMiG7DEru2TnE6 /jMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=uozrw6RGE7WXQ8lAo+b3R158z6Z0HSfakkNDktIK99E=; b=ReW4YRJYY5Tvs1iJsDTqiVHIhSkWSDfHRhi/bIOtav97wcjuwn8MHWf0GUqMnLg7+i HLwIXeb0hwVBVCV4fPe3p3AuaiUy6BzbsKIgwo6tnAELpSNWVd7J9OepokLY4OkkA7AM jm/dxe845shHuBdig4ypKt/sd5U7OVIvxRY6OnGtLF70ny5MUyZNS+htA+oLEDEaKnBa fKTjEPdesE45cNtgVLPRdTjl0o4cWwq86lHj95YtBrk0+zdEqYTaddKUEUeI+XqC6wDq NcdViuFs83QtsNt31HdWacaXQgtgY1q1EJuJtuJfTW78O9T8YRmiXSUSn/3Ecjqg2wAj n1/A== X-Gm-Message-State: AJIora+4Bdo2+MRijUyaqDLfy8H12aokjPMX2nEVXQL4uELqORtZ9sd9 O8iODSiR9n0hotqR2ZlQCJIfJYs1RvQ= X-Google-Smtp-Source: AGRyM1u0WKLp4ko+LeymXaf4h7xUBgPeGgagjGv1QtJhhzOxSDb10eTr7n40daJJTq5ObDwOaRnBhg== X-Received: by 2002:adf:d229:0:b0:21a:3916:84ff with SMTP id k9-20020adfd229000000b0021a391684ffmr11303371wrh.349.1655555058354; Sat, 18 Jun 2022 05:24:18 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.185]) by smtp.gmail.com with ESMTPSA id f11-20020a05600c4e8b00b003973a3fe4fasm9513719wmq.42.2022.06.18.05.24.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Jun 2022 05:24:17 -0700 (PDT) Message-ID: <9c4aa124-cb1a-ae5d-21ae-64ec3a758652@gmail.com> Date: Sat, 18 Jun 2022 15:24:14 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS) Content-Language: en-US To: Peng Fan Cc: "u-boot@lists.denx.de" , "tharvey@gateworks.com" , "sbabic@denx.de" , "festevam@gmail.com" , "trini@konsulko.com" , Simon Glass , "Peng Fan (OSS)" References: <20220603071715.15212-1-peng.fan@oss.nxp.com> <20220603071715.15212-8-peng.fan@oss.nxp.com> <6c1ddda1-2763-07a0-95bd-1f8ba670af27@gmail.com> From: Alper Nebi Yasak In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 15/06/2022 02:25, Peng Fan wrote: >> Subject: Re: [PATCH 7/8] binman_sym: guard with >> CONFIG_IS_ENABLED(BINMAN_SYMBOLS) >> >> On 13/06/2022 05:34, Peng Fan (OSS) wrote: >>> 在 2022/6/11 20:44, Alper Nebi Yasak 写道: >>>> CONFIG_IS_ENABLED(BINMAN) doesn't work, but >> IS_ENABLED(CONFIG_BINMAN) >>>> worked for me. I see all 8 symbols in spl/u-boot-spl.sym. I can send >>>> you a git branch if you want? >>> >>> But now with your suggestion, that means all i.MX8M boards should use >>> the i.MX binman symbols, that is not expected. The i.MX driver code is >>> expected to support w/o i.MX binman symbols. >> >> In my series I'll add a macro like BINMAN_SYMS_OK that is true if binman wrote >> the declared symbols, and false if it didn't. Then you can check 'if >> (BINMAN_SYMS_OK)' to decide if the driver should use the symbols. >> It'll take a day or two for me to test and send. If the macro isn't good enough, >> maybe you can add a new config for the driver's binman symbols. > > Thanks for helping, please also share me a git repo. I've sent a v2 for my series [1], and pushed a branch to my repo [2] with your changes added on top of mine. [1] spl: binman: Fixes for BINMAN_SYMBOLS https://lore.kernel.org/u-boot/20220618121316.12061-1-alpernebiyasak@gmail.com/T/ [2] alpernebbi/u-boot at imx-ddr-binman-symbols https://github.com/alpernebbi/u-boot/tree/imx-ddr-binman-symbols >> >> (Is there any i.MX8M board that won't have working symbols for ddr_fw files >> after this series?) > > I think NO, but I still prefer symbols could be disabled on demand, some NXP > downstream validation boards not have symbols enabled. > > Thanks, > Peng.