Re: [PATCH 2/6] rename NET to NET_LEGACY

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Simon,

On 4/20/26 9:42 PM, Simon Glass wrote:
> Hi Quentin,
> 
> On 2026-04-20T11:36:06, Quentin Schulz <foss+uboot@0leil.net> wrote:
>> rename NET to NET_LEGACY
>>
>> Highlight that NET really is the legacy networking stack by renaming the
>> option to NET_LEGACY.
>>
>> This requires us to add an SPL_NET_LEGACY alias to SPL_NET as otherwise
>> CONFIG_IS_ENABLED(NET_LEGACY) will not work for SPL.
>>
>> The "depends on !NET_LWIP" for SPL_NET clearly highlights that it is
>> using the legacy networking app so this seems fine to do.
>>
>> This also has the benefit of removing potential confusion on NET being a
>> specific networking stack instead of 'any' network stack.
>>
>> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> 
>> diff --git a/doc/develop/bootstd/overview.rst b/doc/develop/bootstd/overview.rst
>> @@ -422,7 +422,7 @@ includes the full set of commands, more error messages when things go wrong and
>> -several filesystem and network features (if CONFIG_NET is enabled) so that
>> +several filesystem and network features (if CONFIG_NET_LEGACY is enabled) so that
> 
> Shouldn't this be left alone? Or perhaps restored in patch 4?
> 
> BOOTSTD_DEFAULTS selects BOOT_DEFAULTS which enables network commands
> conditionally on !NO_NET, meaning any network stack.
> 
This patch series is about renaming stuff, not fixing stuff (though you 
can see some trivial "fixes" in patch 5 and 6).

I agree with you that this needs to be switched to (new) CONFIG_NET. 
I'll try to not forget adding it to a v2 (as a separate patch) if 
there's a need for one, or send a follow-up patch.

>> diff --git a/cmd/ufetch.c b/cmd/ufetch.c
>> @@ -159,7 +159,7 @@ static int do_ufetch(struct cmd_tbl *cmdtp, int flag, int argc,
>> -                     if (IS_ENABLED(CONFIG_NET))
>> +                     if (IS_ENABLED(CONFIG_NET_LEGACY))
>>                                printf('Net');
> 
> Similar question here.
> 

See above.

>> diff --git a/board/siemens/iot2050/board.c b/board/siemens/iot2050/board.c
>> @@ -232,7 +232,7 @@ void set_board_info_env(void)
>> -     if (IS_ENABLED(CONFIG_NET)) {
>> +     if (IS_ENABLED(CONFIG_NET_LEGACY)) {
> 
> and here
> 

See above. This one seems ok, but I am not really planning to modify 
individual boards that I cannot test. This change would mean in a way 
that CONFIG_NET_LWIP has been tested with that board, which possibly 
isn't the case and I cannot guarantee that either.

Cheers,
Quentin