From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D53C8C433F5 for ; Sat, 15 Jan 2022 21:02:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 600AA8351A; Sat, 15 Jan 2022 22:02:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VpOcjibv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AA50F83531; Sat, 15 Jan 2022 22:02:14 +0100 (CET) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0DAAE83518 for ; Sat, 15 Jan 2022 22:02:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.bossman075@gmail.com Received: by mail-qv1-xf2c.google.com with SMTP id a8so13847649qvx.2 for ; Sat, 15 Jan 2022 13:02:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=vGm3bU58LS6YgpgQIE78A7wOt/3ScWh+Ftusesx6bR8=; b=VpOcjibvDGqDIW/Sc5phrvMOXsTMjX1HgEs8F2yPKocmCNw4CJZ0NJ3wd8zt1PVqhi FtWD8yXj90koSw5ZDMhlQU4h6EQxo0n/hvtZfxZs6i/mskivJDL61CEUcSQk+ilv0zQE OrMtY+1ynKlbnIsyV/NlSfx9RSSyDqCVNNOtzLdfqwH70HdTiRhvS7+ab5GDynghGm1r dyy0nWwnLA5YpWPpvug8DrMRh29UxWM4CYgwjnk/tv8RItqyoeQUjGHRuMZQtouSIDRf w2qXJSzdt+pbcXICWW98v2DHJ/mXcd6iJfU7SqYLTBkIu5JI00zu2xr5hBjBbOUGaqdi qL1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=vGm3bU58LS6YgpgQIE78A7wOt/3ScWh+Ftusesx6bR8=; b=IAXOtobhsnS//CsUNaN9F9wEI1vvFyErW4HAXxsQbdzfdRuWdOC0qb8JNh4LJ+xyD3 dojLMx8dXD6dY9WDDsGTfNlg7eI171r/hUavuJp3EmzGj4XZtWPOvod4b8cwtokpkYap FdewK0RpeSa20/h9mA11e/3E3oHuwLTgFwydVN0Za0TFjaScY19gu5xR7BlmIphRx4t9 u1Ch0wn86cNs3hgLG3Jb3tuy6zK9PnSGDjmCJlUrq+BSNiHu/8ZmU4V5Isvlt8nYfi+X bT01jT8Vkc2VMSrlBZWVW7UvVUrsVgNxFyKtoziH+HKX0EHsQ+SctHP2HdnzT2sDPTro YLsQ== X-Gm-Message-State: AOAM532RFuk36sVhuFohHSBKs0996JcsCyzpCDxvN4XcsaCnIXlsRACq XB00QnSiPjFU+s8aOWKn7HQ= X-Google-Smtp-Source: ABdhPJxbxQIG61W0SSU+pxppoA2bR8z0LXxRKLSM8/YSGo6ZaCDGQ9tpFMxr5AwIkLI94d8gFvzxwA== X-Received: by 2002:a05:6214:29c8:: with SMTP id gh8mr3465346qvb.8.1642280530642; Sat, 15 Jan 2022 13:02:10 -0800 (PST) Received: from [10.4.10.38] (146-115-144-188.s4282.c3-0.nwt-cbr1.sbo-nwt.ma.cable.rcncustomer.com. [146.115.144.188]) by smtp.gmail.com with ESMTPSA id br38sm5685388qkb.115.2022.01.15.13.02.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Jan 2022 13:02:10 -0800 (PST) Message-ID: <9ea3dfed-515e-4e60-189f-4e965a2d8e6e@gmail.com> Date: Sat, 15 Jan 2022 16:02:05 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 00/11] Add support for SUNIV and F1C100s. Content-Language: en-US To: Tnze Jdao , "u-boot@lists.denx.de" Cc: "giulio.benetti@benettiengineering.com" References: From: Jesse Taube In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 1/10/22 00:13, Tnze Jdao wrote: > I tested this patch and tried to run it on my LicheePi Nano. It works, but I found there is WARNINGs when compile the code: > ------- > include/configs/sunxi-common.h:128:0: warning: "CONFIG_ENV_SECT_SIZE" redefined > #define CONFIG_ENV_SECT_SIZE 0x1000 Ah I will move this it should be moved to defconfig thx for pointing this out. > > In file included from ././include/linux/kconfig.h:4:0, > from :0: > include/generated/autoconf.h:296:0: note: this is the location of the previous definition > #define CONFIG_ENV_SECT_SIZE 0x1 Not entirely sure how it got defined here, it doesn't get defined in my generated config. > > In file included from include/configs/suniv.h:12:0, > from include/config.h:4, > from include/common.h:16, > from lib/slre.c:24: > -------- > And I think the problem is the CONFIG_ENV_SECT_SIZE should be (and required to) defined in the config file rather than at include/configs/sunxi-common.h:128 Im sorry for the late reply the email got lost.