From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Etienne Carriere <etienne.carriere@foss.st.com>, <u-boot@lists.denx.de>
Cc: Jens Wiklander <jens.wiklander@linaro.org>,
Patrick Delaunay <patrick.delaunay@foss.st.com>
Subject: Re: [PATCH 1/2] tee: optee: don't fail on services enumeration failure
Date: Fri, 1 Dec 2023 11:05:03 +0100 [thread overview]
Message-ID: <9fce2a8a-9305-4080-806d-cf1e80c58f24@foss.st.com> (raw)
In-Reply-To: <20231129123753.1906956-1-etienne.carriere@foss.st.com>
On 11/29/23 13:37, Etienne Carriere wrote:
> Change optee probe function to only warn when service enumeration
> sequence fails instead of reporting an optee driver probe failure.
> Indeed U-Boot can still use OP-TEE even if some OP-TEE services are
> not discovered.
>
> Fixes: 94ccfb78a4d6 ("drivers: tee: optee: discover OP-TEE services")
> Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>
> ---
> drivers/tee/optee/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
> index 9a9b697e91..5308dd58ce 100644
> --- a/drivers/tee/optee/core.c
> +++ b/drivers/tee/optee/core.c
> @@ -841,7 +841,7 @@ static int optee_probe(struct udevice *dev)
> if (IS_ENABLED(CONFIG_OPTEE_SERVICE_DISCOVERY)) {
> ret = bind_service_drivers(dev);
> if (ret)
> - return ret;
> + dev_warn(dev, "optee service enumeration failed: %d\n", ret);
> } else if (IS_ENABLED(CONFIG_RNG_OPTEE)) {
> /*
> * Discovery of TAs on the TEE bus is not supported in U-Boot:
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
next prev parent reply other threads:[~2023-12-01 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 12:37 [PATCH 1/2] tee: optee: don't fail on services enumeration failure Etienne Carriere
2023-11-29 12:37 ` [PATCH 2/2] tee: optee: don't enumerate services if there ain't any Etienne Carriere
2023-12-01 10:05 ` Patrice CHOTARD
2023-12-05 15:20 ` Jens Wiklander
2023-12-19 17:46 ` Tom Rini
2023-12-01 10:05 ` Patrice CHOTARD [this message]
2023-12-05 15:14 ` [PATCH 1/2] tee: optee: don't fail on services enumeration failure Jens Wiklander
2023-12-19 17:46 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fce2a8a-9305-4080-806d-cf1e80c58f24@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=etienne.carriere@foss.st.com \
--cc=jens.wiklander@linaro.org \
--cc=patrick.delaunay@foss.st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox