From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DE3BEB64D7 for ; Fri, 23 Jun 2023 11:52:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4398886332; Fri, 23 Jun 2023 13:52:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MLUYRWy0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3296C8638B; Fri, 23 Jun 2023 13:52:02 +0200 (CEST) Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 77A2986167 for ; Fri, 23 Jun 2023 13:51:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=clamor95@gmail.com Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-4f883420152so611059e87.1 for ; Fri, 23 Jun 2023 04:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687521118; x=1690113118; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=lvfpdIxXMnlHOR96DFqRzvLFKqbMHd6qRxJsoUD+RMY=; b=MLUYRWy0t8tXrWEjnSuuaRmQ2Elw+aNEq6kO2BXmRLgMfK/+lQ0J9x0qWKvJ9CxtH9 636Y1roFaactgsGEy4SdLob4IoThoyrtzrPzPMCUKAIT5uFg+tUBABOAvHIN3v+GkWfJ yfSk6m0A8VvrUgPikDVG2ZLkfSgRjMFukchLZhMkXMmCr5HMKjmN/Z9TThZuQS+3vMns ClDKQw4SvgKzuVes2Mm8ROFZO/slL3VjWe3Iij2fVOHtQTHoNSNL2Yae89xuv+39kMcO hWFY6jyQJUfUXT5qCWk7AIbzU6XNpEAEqMT3k7Lcar51XgOuMVdcSY2lxhermenBqcA6 SoUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687521118; x=1690113118; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=lvfpdIxXMnlHOR96DFqRzvLFKqbMHd6qRxJsoUD+RMY=; b=GKhpng8wlQgTPDfiufnOSDQjix1D8cbNT4gzlsCt4TJ2QB8yqOMy7HIdEumqZOFJLs NEiTap7YDVi/eXk1HbpUsZ87okFnXwEbAQnqoPFZeixlfW6IKD5OVyKRqHN2mhjbdQ/l gZ2P8XsgGEQK5MH659zc4Qpgfo1433GAhJjNiHv2LmdDzNYNcHAQvrxErLCxBq2K6q2b aGeBBVR8PRMAdO4uMm8Kbw8tZONNUOLiVkUm9vvFNVsQ/aiMi4VXYMRTcAhUj6zypw8h jElKihBuvYYpxnuY8QphPaKMitYvsDennhPjLOWO2HPftM14sIM9ZXcbWNmFQU9CoaFs NSuw== X-Gm-Message-State: AC+VfDw4i3369iOJRRA+V4n2L6cO0BuPANqDSrsV0cidWHuA8i8cVMry ZMuzXpRcdiD7HBYfe4UONBo= X-Google-Smtp-Source: ACHHUZ7maZwlZKxeme5AHcWL0/H1HvStEp5i7hgyk4aTSGcl6kmSrdD5aWvez3UaU8rwqmo6cF/V5g== X-Received: by 2002:ac2:5b51:0:b0:4f9:571d:c50d with SMTP id i17-20020ac25b51000000b004f9571dc50dmr5584493lfp.46.1687521117384; Fri, 23 Jun 2023 04:51:57 -0700 (PDT) Received: from [127.0.0.1] ([91.204.85.69]) by smtp.gmail.com with ESMTPSA id d4-20020a5d5384000000b003112b38fe90sm9369618wrv.79.2023.06.23.04.51.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 04:51:57 -0700 (PDT) Date: Fri, 23 Jun 2023 14:51:54 +0300 From: Svyatoslav Ryhel To: Thierry Reding CC: Thierry Reding , Tom Warren , Tom Rini , Simon Glass , =?ISO-8859-1?Q?Jonas_Schw=F6bel?= , u-boot@lists.denx.de Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v7_4/7=5D_board=3A_asus=3A_transforme?= =?US-ASCII?Q?r=3A_add_ASUS_Transformer_T30_family_support?= User-Agent: K-9 Mail for Android In-Reply-To: References: <20230623055600.246416-1-clamor95@gmail.com> <20230623055600.246416-5-clamor95@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean 23 =D1=87=D0=B5=D1=80=D0=B2=D0=BD=D1=8F 2023 =D1=80=2E 14:32:30 GMT+03:00,= Thierry Reding =D0=BD=D0=B0=D0=BF=D0=B8=D1= =81=D0=B0=D0=B2(-=D0=BB=D0=B0): >On Fri, Jun 23, 2023 at 08:55:57AM +0300, Svyatoslav Ryhel wrote: >[=2E=2E=2E] >> diff --git a/board/asus/transformer-t30/pinmux-config-transformer=2Eh b= /board/asus/transformer-t30/pinmux-config-transformer=2Eh >> new file mode 100644 >> index 0000000000=2E=2E96ff45d375 >> --- /dev/null >> +++ b/board/asus/transformer-t30/pinmux-config-transformer=2Eh >> @@ -0,0 +1,365 @@ >> +/* SPDX-License-Identifier: GPL-2=2E0 */ >> +/* >> + * Copyright (c) 2010-2013, NVIDIA CORPORATION=2E All rights reserved= =2E >> + * >> + * Copyright (c) 2021, Svyatoslav Ryhel=2E >> + */ > >I don't recall if we discussed this during upstreaming of the Linux >device tree files, but shortly after the initial support for Tegra20 and >Tegra30 was upstreamed (both in U-Boot and in Linux) we decided to move >towards generating the pinmux configuration for the various consumers >(i=2Ee=2E U-Boot and Linux) from data tables using a set of scripts=2E Th= is >was done because we noticed that various inconsistencies kept creeping >into the various drivers/tables=2E > >You can find the scripts for this here: > > https://github=2Ecom/NVIDIA/tegra-pinmux-scripts > >I think there'd be some benefit if these new boards were also converted >to use these scripts=2E True, but there is no driver for pinmux which can utilize device tree, ins= tead u-boot relies on board header=2E I see the benefit of these pinmux nod= es only if I can verify that they are correct and do not brake devices=2E W= ould be really bad if at some point devices brake cause nodes were not test= ed=2E Additionally, shouldn't all supported boards be converted first? Best regards, Svyatoslav R=2E >Thierry