From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/5] Add Ethernet hardware MAC address framework to usbnet
Date: Wed, 13 Apr 2011 13:28:46 -0700 [thread overview]
Message-ID: <BANLkTimPy5dYopDkRttoWWduCs81KacCcQ@mail.gmail.com> (raw)
In-Reply-To: <4DA60638.8090908@aribaud.net>
On Wed, Apr 13, 2011 at 1:23 PM, Albert ARIBAUD
<albert.u.boot@aribaud.net> wrote:
> Le 13/04/2011 05:48, Mike Frysinger a ?crit :
>
>>> ? ? ? ? ? ? ? ? ? ? ?if (strchr(dev->name, ' '))
>>> - ? ? ? ? ? ? ? ? ? ? ? ? ? ?puts("\nWarning: eth device name has a space!\n");
>>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ?puts("\nWarning: eth device name has a "
>>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?"space!\n");
>>
>> please dont change unrelated things. ?that newline should be there, and this
>> string shouldnt be broken up.
>
> Technically it is not. A C string constant can be made of several
> quote-delimited string literals separated by whitespace -- so this
> change is a no-op, and does not remove any newline btw. I suspect the
> change is to keep checkpatch.pl happy about the line length.
Yes it was, but on-line reviewers are noisier than checkpatch so have
changed it. Also I was actually reverting a previous change so there
is no need for my change at all. But thank you for your kind
understanding.
I do find it quite confusing adding code which fits with U-Boot's
coding style to a file which doesn't :-)
Regards,
Simon
>
> Amicalement,
> --
> Albert.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
next prev parent reply other threads:[~2011-04-13 20:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 0:46 [U-Boot] [PATCH v2 1/5] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter Simon Glass
2011-04-13 0:46 ` [U-Boot] [PATCH v2 2/5] Add Ethernet hardware MAC address framework to usbnet Simon Glass
2011-04-13 3:48 ` Mike Frysinger
2011-04-13 20:23 ` Albert ARIBAUD
2011-04-13 20:28 ` Simon Glass [this message]
2011-04-13 21:05 ` Mike Frysinger
2011-04-14 5:01 ` Albert ARIBAUD
2011-04-13 23:30 ` Mike Frysinger
2011-04-14 5:58 ` Albert ARIBAUD
2011-04-14 6:12 ` Mike Frysinger
2011-04-14 6:51 ` Albert ARIBAUD
2011-04-15 7:56 ` Mike Frysinger
2011-04-15 8:13 ` Albert ARIBAUD
2011-04-15 8:25 ` Mike Frysinger
2011-04-15 9:34 ` Albert ARIBAUD
2011-04-13 0:46 ` [U-Boot] [PATCH v2 3/5] Add documentation for USB Host Networking Simon Glass
2011-04-13 0:46 ` [U-Boot] [PATCH v2 4/5] Put common autoload code into AutoLoad() function Simon Glass
2011-04-13 0:46 ` [U-Boot] [PATCH v2 5/5] Allow tftp server to be different from bootp/dhcp server Simon Glass
2011-04-13 3:44 ` [U-Boot] [PATCH v2 1/5] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter Mike Frysinger
2011-04-13 18:47 ` Simon Glass
2011-04-13 19:45 ` Wolfgang Denk
2011-04-13 21:13 ` Simon Glass
2011-04-13 21:21 ` Simon Glass
2011-04-13 21:43 ` Simon Glass
2011-04-13 21:50 ` Wolfgang Denk
2011-04-13 21:08 ` Mike Frysinger
2011-04-13 22:31 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimPy5dYopDkRttoWWduCs81KacCcQ@mail.gmail.com \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox