public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Po-Yu Chuang <ratbert.chuang@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 4/4] ftsmc020: move ftsmc020 static mem controller to driver/mtd
Date: Thu, 28 Apr 2011 15:47:06 +0800	[thread overview]
Message-ID: <BANLkTimsEDC_CdJWZP-Ragsxyiq30E+cAw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTik1-18oHW1hEgzPT2f3wxPDZOm03Q@mail.gmail.com>

Hi Macpaul,

On Thu, Apr 28, 2011 at 3:33 PM, Macpaul Lin <macpaul@gmail.com> wrote:
> Hi Po-Yu,
>
> 2011/4/28 Po-Yu Chuang <ratbert.chuang@gmail.com>:
>> Hi Macpaul,
>>
>>> -#include <asm/arch/ftsmc020.h>
>>> +#define CONFIG_FTSMC020

This is for drivers/mtd/Makefile.

>>> +#include <faraday/ftsmc020.h>
>>>
>>> ?#define FTSMC020_BANK0_CONFIG ?(FTSMC020_BANK_ENABLE ? ? ? ? ? ? | ? ? \
>>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? FTSMC020_BANK_BASE(PHYS_FLASH_1) | ? ? \
>>> @@ -196,6 +197,7 @@
>>> ? ? ? ?{ FTSMC020_BANK0_CONFIG, FTSMC020_BANK0_TIMING, }, ? ? ?\
>>> ? ? ? ?{ FTSMC020_BANK1_CONFIG, FTSMC020_BANK1_TIMING, }, ? ? ?\
>>> ?}
>>> +#endif /* CONFIG_FTSMC020 */
>>
>> Looks like this #endif is unnecessary?
>
> At the time the patch has been generated, I could bulid a320evb.
> I'm not in the office in these 2 days.
> Could I check it and reply to you later?
>
> According to your reply, I guess I was meant to support
> #define CONFIG_FTSMC020 in board's config file.
>
> I'll check it later after 10:00 in Taiwan time. Sorry.

After removed the #endif line, it builds again.
I will submit a simple patch. Please check it later.

Thanks, :-)
Po-Yu Chuang

  reply	other threads:[~2011-04-28  7:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-16  7:37 [U-Boot] [PATCH v3 1/4] ftahbc020s: Faraday FTAHBC020s AHB Bus Controller Macpaul Lin
2011-04-16  7:37 ` [U-Boot] [PATCH v3 2/4] ftsdmc021: add register definitions of ftsdmc021 Macpaul Lin
2011-04-23  7:24   ` Albert ARIBAUD
2011-04-16  7:37 ` [U-Boot] [PATCH v3 3/4] ftsdmc020: move ftsdmc020.h to include/faraday Macpaul Lin
2011-04-23  7:33   ` Albert ARIBAUD
2011-04-16  7:37 ` [U-Boot] [PATCH v3 4/4] ftsmc020: move ftsmc020 static mem controller to driver/mtd Macpaul Lin
2011-04-23  7:34   ` Albert ARIBAUD
2011-04-28  6:45   ` Po-Yu Chuang
2011-04-28  7:33     ` Macpaul Lin
2011-04-28  7:47       ` Po-Yu Chuang [this message]
2011-04-28  7:53         ` Macpaul Lin
2011-04-23  7:23 ` [U-Boot] [PATCH v3 1/4] ftahbc020s: Faraday FTAHBC020s AHB Bus Controller Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTimsEDC_CdJWZP-Ragsxyiq30E+cAw@mail.gmail.com \
    --to=ratbert.chuang@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox