From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Erickson Date: Wed, 07 May 2008 06:53:23 -0700 Subject: [U-Boot-Users] [PATCH] Propagate Error Status to the Shell on fw_printenv Errors In-Reply-To: <87myn2vaam.fsf@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 5/7/08 12:32 AM, Markus Klotzb?cher wrote: > Wolfgang Denk writes: >> In message <87myn2ehqm.fsf@denx.de> you wrote: > Oh right, yes. Shouldn't post to lists before drinking coffee in the > morning. > >> However, the addition of this feature is undocumented (not mentioned >> in the commit message), and I don;t see why we should restrict it to a >> single variable - it may be useful to print several values here, too, >> for example like that: >> >> $ set `fw_printenv -n netdev ipaddr netmask` >> $ ifconfig $1 $2 netmask $3 >> >> [Well, I know that's a bad example because it's missing all error >> checking, but you get the idea.] > > Yes, that would nice indeed. Grant, care to add this? And please update > the documentation in any case. Markus, Thanks for the comments. As suggested by Wolfgang, the "-n" option was pre-existing in the code before my patch. I can investigate extending "-n" as described above; however, the caveat is that the user knows that the values of some variables may have spaces. In such a case, he/she might find the above example to not work as expected. Anyway, hopefully Wolfgang can ACK the patch as is and I can look at extending the "-n" option as another separate effort. Regards, Grant PS: To which documentation are you referring? The comments in the source or the DULG?