public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Grant Erickson <gerickson@nuovations.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add PPC405 External Bus Controller (EBC) Register Field Mnemonics
Date: Wed, 11 Jun 2008 16:10:18 -0700	[thread overview]
Message-ID: <C475A96A.FBA7%gerickson@nuovations.com> (raw)
In-Reply-To: <20080611230048.A152324345@gemini.denx.de>

On 6/11/08 4:00 PM, Wolfgang Denk wrote:
> In message <1210886606-12929-1-git-send-email-gerickson@nuovations.com> you
> wrote:
>> Added preprocessor definitions for External Bus Controller (EBC)
>> configuration, bank configuration and access parameter register fields
>> along with a macro for defining them and verifying them against the
>> data sheet or user's manual easier.
>> 
>> Tested against AMCC "Haleakala".
>> 
>> Signed-off-by: Grant Erickson <gerickson@nuovations.com>
> 
> Are these definitions being used anywhere?
> 
> I tend to drop this patch because it seems  to  be  just  dead  code.
> Stefan, do you agree?
> 
> 
> Best regards,
> 
> Wolfgang Denk

Wolfgang,

These are actually now used in cpu/ppc4xx/start.S and are probably already
included in the latest 4xx pull from Stefan. So, this patch might be a no-op
at this point.

Regardless, while they are not used in include/configs/kilauea.h and
include/configs/makalu.h yet (but both could and should be) I have used them
in the include/config/<board>.h for the new boards I am supporting for a
client. They make it much easier to decode BxAP and BxCR settings than an
arbitrary 32-bit hex value.

Regards,

Grant

  reply	other threads:[~2008-06-11 23:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-15 21:23 [U-Boot-Users] [PATCH] Add PPC405 External Bus Controller (EBC) Register Field Mnemonics Grant Erickson
2008-06-11 23:00 ` Wolfgang Denk
2008-06-11 23:10   ` Grant Erickson [this message]
2008-06-12  6:37     ` Wolfgang Denk
2008-06-12  9:58       ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C475A96A.FBA7%gerickson@nuovations.com \
    --to=gerickson@nuovations.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox