public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Grant Erickson <gerickson@nuovations.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] Suppressing Diagnostic Output for 'fw_setenv'
Date: Fri, 29 Aug 2008 20:32:39 -0700	[thread overview]
Message-ID: <C4DE0D67.115B5%gerickson@nuovations.com> (raw)

The u-boot companion command line tool 'fw_setenv' emits verbose output
during a set operation of the form:

    Unlocking flash...
    Done
    Erasing old environment...
    Done
    Writing environment to /dev/mtd4...
    Done
    Locking ...
    Done

While this is nice for debugging and troubleshooting, it is a bit verbose in
a production environment. I propose two alternatives for suppressing this
output:

1) Compile-time: Change 'printf' to 'debug' in which case the above
   diagnostics will only be output when the tool is built with 'DEBUG'
   asserted.

2) Run-time: Change the implementation such that the invocation usage of
   'fw_setenv' is:

    Usage: fw_setenv [ -q ] name [ value ... ]

I'd favor (2); however, I welcome strong opinions one way or another before
I submit a patch.

Regards,

Grant

             reply	other threads:[~2008-08-30  3:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-30  3:32 Grant Erickson [this message]
2008-08-30  5:51 ` [U-Boot] [RFC] Suppressing Diagnostic Output for 'fw_setenv' Markus Klotzbücher
2008-08-30  6:52 ` [U-Boot] [PATCH] " Grant Erickson
2008-08-30  7:01   ` Markus Klotzbücher
2008-09-06 22:28   ` Wolfgang Denk
2008-09-07 19:41     ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C4DE0D67.115B5%gerickson@nuovations.com \
    --to=gerickson@nuovations.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox