[U-Boot] [PATCH v6 20/20] RFC: Deprecate MAKEALL

York Sun
2014-08-11T18:23:13Z

On 08/09/2014 02:33 PM, Simon Glass wrote:
> Since buildman now includes most of the features of MAKEALL it is probably
> time to talk about deprecating MAKEALL.
>
> Comments welcome.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2:
> - Add new patch to fix existing typos
>
> MAKEALL | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/MAKEALL b/MAKEALL
> index 929fe88..dbbf74b 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -60,6 +60,10 @@ usage()
> exit ${ret}
> }
>
> +echo "** Note: MAKEALL is deprecated - please use buildman instead"
> +echo "** See tools/buildman/README for details"
> +echo
> +
> SHORT_OPTS="ha:c:v:s:b:lmMCnr"
> LONG_OPTS="help,arch:,cpu:,vendor:,soc:,board:,list,maintainers,mails,check,continue,rebuild-errors"
>
>
Simon,

This doesn't stop this patch. Just a suggestion.

It may be helpful to print this message at the end of output of MAKEALL. I check
the summary at the end of run carefully, but not paying too much attention at
the beginning. Beside, if I have a lot of output I may miss the beginning.

Another suggestion for future patch is to use return value for buildman. For
now, I have to check if err files are created during building.

York