[U-Boot] [PATCH v3] powerpc/85xx: enable some P1/P2 boards mtdparts for nor flash

[York Sun <yorksun@freescale.com>]

Yangbo,

On 8/17/14 7:03 PM, "Yangbo Lu" <yangbo.lu@freescale.com> wrote:

>Enable these boards mtdparts for nor flash:
>p1020rdb-pd, p1021rdb-pc, p1022ds, p1025twr, and p2020rdb-pc.
>
>Signed-off-by: Xie Xiaobo <X.Xie@freescale.com>
>Signed-off-by: Yangbo Lu <yangbo.lu@freescale.com>
>Cc: York Sun <yorksun@freescale.com>
>Cc: Scott Wood <scottwood@freescale.com>
>---
>Changes for v2:
>	- changed commit message
>	- fixed max line length problem in code
>Changes for v3:
>	- added a Cc to York Sun
>---
> include/configs/P1022DS.h      | 12 ++++++++++++
> include/configs/p1_p2_rdb_pc.h | 31 +++++++++++++++++++++++++++++++
> include/configs/p1_twr.h       | 12 ++++++++++++
> 3 files changed, 55 insertions(+)
>
>diff --git a/include/configs/P1022DS.h b/include/configs/P1022DS.h
>index 139d4fe..4480270 100644
>--- a/include/configs/P1022DS.h
>+++ b/include/configs/P1022DS.h
>@@ -620,6 +620,18 @@
> #endif
> 
> /*
>+ * Dynamic MTD Partition support with mtdparts
>+ */
>+#define CONFIG_MTD_DEVICE
>+#define CONFIG_MTD_PARTITIONS
>+#define CONFIG_CMD_MTDPARTS
>+#define CONFIG_FLASH_CFI_MTD
>+#define MTDIDS_DEFAULT "nor0=e8000000.nor"
>+#define MTDPARTS_DEFAULT "mtdparts=e8000000.nor:48m(ramdisk)," \
>+			"14m(diagnostic),2m(dink),6m(kernel),58112k(fs)," \
>+			"512k(dtb),768k(u-boot)"
>+

Don't you need to consider both 32- and 36-bit physical address for the
flash base here? The same comment applies to p1_p2_rdb_pc.h as well.

York

>