Re: [PATCH v6 01/18] video: tegra20: dc: diverge DC per-SOC

Thierry Reding
2024-04-19T16:34:45Z

[-- Attachment #1: Type: text/plain, Size: 1885 bytes --]

On Fri Apr 19, 2024 at 6:26 PM CEST, Thierry Reding wrote:
> On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote:
> [...]
> > diff --git a/arch/arm/include/asm/arch-tegra114/display.h b/arch/arm/include/asm/arch-tegra114/display.h
> > new file mode 100644
> > index 0000000000..9411525799
> > --- /dev/null
> > +++ b/arch/arm/include/asm/arch-tegra114/display.h
> > @@ -0,0 +1,28 @@
> > +/* SPDX-License-Identifier: GPL-2.0+ */
> > +/*
> > + * (C) Copyright 2010
> > + * NVIDIA Corporation <www.nvidia.com>
> > + */
> > +
> > +#ifndef __ASM_ARCH_TEGRA_DISPLAY_H
> > +#define __ASM_ARCH_TEGRA_DISPLAY_H
> > +
> > +#include <asm/arch-tegra/dc.h>
> > +
> > +/* This holds information about a window which can be displayed */
> > +struct disp_ctl_win {
> > + enum win_color_depth_id fmt; /* Color depth/format */
> > + unsigned int bpp; /* Bits per pixel */
> > + phys_addr_t phys_addr; /* Physical address in memory */
> > + unsigned int x; /* Horizontal address offset (bytes) */
> > + unsigned int y; /* Veritical address offset (bytes) */
> > + unsigned int w; /* Width of source window */
> > + unsigned int h; /* Height of source window */
> > + unsigned int stride; /* Number of bytes per line */
> > + unsigned int out_x; /* Left edge of output window (col) */
> > + unsigned int out_y; /* Top edge of output window (row) */
> > + unsigned int out_w; /* Width of output window in pixels */
> > + unsigned int out_h; /* Height of output window in pixels */
> > +};
> > +
> > +#endif /*__ASM_ARCH_TEGRA_DISPLAY_H*/
>
> One of the earlier patches in the series gets rid of this per-SoC header
> file in favor of a common one. Did this end up here by mistake? It
> doesn't seem to be used.

Nevermind, my MUA sorted these patches weirdly, so it appeared as if
this was later in the series than it actually was.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]