Re: [PATCH v6 12/18] video: tegra20: dc: parameterize V- and H-sync polarities

Thierry Reding
2024-04-19T17:00:22Z

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote:
> Based on Thierry Reding's Linux commit:
>
> 'commit 1716b1891e1de05e2c20ccafa9f58550f3539717
> ("drm/tegra: rgb: Parameterize V- and H-sync polarities")'
>
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
> arch/arm/include/asm/arch-tegra/dc.h | 5 +++++
> drivers/video/tegra20/tegra-dc.c | 22 ++++++++++++++++++++--
> 2 files changed, 25 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-tegra/dc.h b/arch/arm/include/asm/arch-tegra/dc.h
> index 6444af2993..ca3718411a 100644
> --- a/arch/arm/include/asm/arch-tegra/dc.h
> +++ b/arch/arm/include/asm/arch-tegra/dc.h
> @@ -443,6 +443,11 @@ enum win_color_depth_id {
> #define WINDOW_D_SELECT BIT(7)
> #define WINDOW_H_SELECT BIT(8)
>
> +/* DC_COM_PIN_OUTPUT_POLARITY1 0x307 */
> +#define LHS_OUTPUT_POLARITY_LOW BIT(30)
> +#define LVS_OUTPUT_POLARITY_LOW BIT(28)
> +#define LSC0_OUTPUT_POLARITY_LOW BIT(24)

This definition seems to be unused, other than that:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]