From: "Michael Walle" <mwalle@kernel.org>
To: "Simon Glass" <sjg@chromium.org>,
"Mattijs Korpershoek" <mkorpershoek@baylibre.com>
Cc: "Tom Rini" <trini@konsulko.com>, <u-boot@lists.denx.de>
Subject: Re: [PATCH v2] boot: android: fix booting without a ramdisk
Date: Wed, 31 Jul 2024 17:33:25 +0200 [thread overview]
Message-ID: <D33U0UZY7230.18W0UEVD0508X@kernel.org> (raw)
In-Reply-To: <CAFLszTip3uwZLy=jL+-BKwD74Wk8j6So_N9TW_P16gpBvLKQRQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
Hi,
> > > - if (ret)
> > > + if (ret == -ENOENT)
> > > + return -ENOPKG;
>
> We normally use -ENOENT for this sort of thing.
That's the way select_ramdisk() is documented. It was actually
introduced by yourself in commit e4c928792e93 ("image: Split up
boot_get_ramdisk()") :)
-michael
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]
next prev parent reply other threads:[~2024-07-31 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 21:36 [PATCH v2] boot: android: fix booting without a ramdisk Michael Walle
2024-07-30 8:51 ` Mattijs Korpershoek
2024-07-31 14:38 ` Simon Glass
2024-07-31 15:33 ` Michael Walle [this message]
2024-08-01 14:42 ` Simon Glass
2024-08-06 10:00 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D33U0UZY7230.18W0UEVD0508X@kernel.org \
--to=mwalle@kernel.org \
--cc=mkorpershoek@baylibre.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox