Re: [PATCH v4 0/2] Refactor tidss_drv and enable early splash on AM625

[Anshul Dalal <anshuld@ti.com>]

On Thu Nov 6, 2025 at 2:28 PM IST, Swamil Jain wrote:
> This series:
> - Refactors tidss_drv                                                    
> - Adds am62x_a53_splashscreen.config to enable splashscreen at u-boot    
>   SPL
>
> Signed-off-by: Swamil Jain <s-jain1@ti.com>
> ---

Tested-by: Anshul Dalal <anshuld@ti.com>

I also went ahead and did a sandbox build and the driver seems to build
fine contrary to what Tom saw[1].

Below are the steps I followed, am I missing something here?
 1. make sandbox_defconfig
 2. Select CONFIG_VIDEO_TIDSS via menuconfig
 3. make -j`nproc`

[1]: https://lore.kernel.org/u-boot/20251105164114.GQ6688@bill-the-cat/

Regards,
Anshul

> Note:
> - As OLDI specific changes are in progress to be synced to upstream DT,
> use this[1] branch to enable SD-MMC splash on AM62X. Upstream DT changes
> can be found here[2][3].
> - Use TI logo file(ti_logo_414x97_32bpp.bmp.gz) from this link[4].
>
> [1]: https://github.com/swamiljain/u-boot/tree/v3_splash_final
> [2]: https://lore.kernel.org/all/20250913064205.4152249-1-s-jain1@ti.com/
> [3]: https://lore.kernel.org/all/20251017115325.1942591-2-s-jain1@ti.com/
> [4]: https://github.com/swamiljain/ti-splash-logo/blob/main/ti_logo_414x97_32bpp.bmp.gz                                                         
> ---
> Changelog v3->v4:
> PATCH 1/2 : Don't include "asm/utils.h" in tidss_drv.c
> PATCH 2/2 : - Move CONFIG_FS_LOADER from am62x_a53_defconfig to
>               splashscreen.config fragment
>             - Minor change in commit message
> Link to v3:
> https://lore.kernel.org/all/20251105163040.4086273-1-s-jain1@ti.com/
>                                                                      
> Changelog v2->v3:                                                       
> - Add splashscreen.config fragment to enable splashscreen               
> - Align OLDI mode detection logic with kernel side upstreamed OLDI      
>   series[1]                                                             
> - Address styling issue mentioned by Devarsh                            
> - Pick up R-by tag for PATCH 1/2                                        
>                                                                         
> Link to v2:                                                             
> https://lore.kernel.org/all/20250725043012.1186886-1-s-jain1@ti.com/    
>                                                                         
> Changelog v1->v2                                                        
> - Iterate through all available OLDIs                                   
> - Move dss_oldi_tx_power from tidss_drv.c to tidss_oldi.c               
> - Rename tidss_attach_active_panel to a more generic name               
> - To handle all active hw video ports, add an array for active hw vps   
> - Iterate through all active hw vps to enable respective clks           
>                                                                         
> Link to v1: https://lore.kernel.org/u-boot/20250603105735.4038240-1-s-jain1@ti.com/
> ---
>
> Devarsh Thakkar (1):
>   configs: am62x_evm_a53_defconfig: Enable A53 splashscreen at u-boot
>     SPL
>
> Swamil Jain (1):
>   drivers: video: tidss: Refactor tidss_drv
>
>  configs/am62x_a53_splashscreen.config |  17 ++
>  configs/am62x_evm_a53_defconfig       |   3 +-
>  drivers/video/tidss/Makefile          |   2 +-
>  drivers/video/tidss/tidss_drv.c       | 236 +++++++++++------
>  drivers/video/tidss/tidss_drv.h       |  40 ++-
>  drivers/video/tidss/tidss_oldi.c      | 364 ++++++++++++++++++++++++++
>  drivers/video/tidss/tidss_oldi.h      |  72 +++++
>  drivers/video/tidss/tidss_regs.h      |  21 --
>  8 files changed, 631 insertions(+), 124 deletions(-)
>  create mode 100644 configs/am62x_a53_splashscreen.config
>  create mode 100644 drivers/video/tidss/tidss_oldi.c
>  create mode 100644 drivers/video/tidss/tidss_oldi.h