From: "Michael Walle" <mwalle@kernel.org>
To: "Tom Rini" <trini@konsulko.com>
Cc: <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/2] drivers: rtc: add PCF85063 support
Date: Mon, 17 Nov 2025 09:13:36 +0100 [thread overview]
Message-ID: <DEATIC39P9JQ.24GJE4VJJVRSB@kernel.org> (raw)
In-Reply-To: <20251114152236.GB6688@bill-the-cat>
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
>> +config RTC_PCF85063
>> + tristate "Enable PCF85063 driver"
>
> tristate is wrong for U-Boot, only bool is meaningful (and I need to go
> update checkpatch.pl to complain about this).
Yeah, sorry, This was a copy and paste error from the very next
config entry. I'll fix it in v2 and add a patch to convert the
existing tristate to bool.
> This is I assume otherwise
> checkpatch warning free and compiles on sandbox?
Yeah, except for the missing maintainers entry.
-michael
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]
next prev parent reply other threads:[~2025-11-17 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 15:12 [PATCH 0/2] Add support for two RTCs Michael Walle
2025-11-14 15:12 ` [PATCH 1/2] drivers: rtc: add PCF85063 support Michael Walle
2025-11-14 15:22 ` Tom Rini
2025-11-17 8:13 ` Michael Walle [this message]
2025-11-17 13:30 ` Tom Rini
2025-11-14 15:12 ` [PATCH 2/2] drivers: rtc: add RV3032 support Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEATIC39P9JQ.24GJE4VJJVRSB@kernel.org \
--to=mwalle@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox