From: "Kaustabh Chakraborty" <kauschluss@disroot.org>
To: "chiffathefox" <chiffathefoxx@gmail.com>, "Marek Vasut" <marex@denx.de>
Cc: "Andrew Goodbody" <andrew.goodbody@linaro.org>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Kaustabh Chakraborty" <kauschluss@disroot.org>,
"Lukasz Majewski" <lukma@denx.de>,
"Maksim Kiselev" <bigunclemax@gmail.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
"Tom Rini" <trini@konsulko.com>, "Ye Li" <ye.li@nxp.com>,
<u-boot@lists.denx.de>
Subject: Re: [PATCH 1/2] clk: clk_resolve_parent_clk(): resolve external clocks by id
Date: Mon, 19 Jan 2026 22:29:51 +0530 [thread overview]
Message-ID: <DFSQ5KRJ79JB.1N3LK2G2G2FDG@disroot.org> (raw)
In-Reply-To: <20260115031114.220888-2-chiffathefoxx@gmail.com>
On 2026-01-15 05:11 +02:00, chiffathefox wrote:
> When referencing clocks in DTS registered by another driver,
> clk_resolve_parent_clk() is supposed to return the name
> of the child device that provides the requested clock.
> However, in reality, it returns the name of the parent DTB
> node (e.g. clock-controller@1a240000). Such devices, for
> instance the exynos7870-cmu-peri driver, do not store any
> clock information in their dev->uclass_priv_ because they
> expect you to call dev->ops->get_rate with the appropriate
> clk->id. So when you try to resolve a clock that depends on
> an externally referenced clock, the resolution fails on the
> parent clock because it doesn't have a dev->uclass_priv_.
> With this change clk_resolve_parent_clk() will take an
> extra step to actually resolve the child device.
>
> Signed-off-by: chiffathefox <chiffathefoxx@gmail.com>
Tested-by: Kaustabh Chakraborty <kauschluss@disroot.org> # exynos-mobile/exynos7870
next prev parent reply other threads:[~2026-01-19 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 3:11 [PATCH 0/2] Improvements to the recent clock rework by marex chiffathefox
2026-01-15 3:11 ` [PATCH 1/2] clk: clk_resolve_parent_clk(): resolve external clocks by id chiffathefox
2026-01-17 1:38 ` Marek Vasut
2026-01-19 16:59 ` Kaustabh Chakraborty [this message]
2026-01-15 3:11 ` [PATCH 2/2] clk: exynos: do not reparent requested clock chiffathefox
2026-01-19 17:00 ` Kaustabh Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFSQ5KRJ79JB.1N3LK2G2G2FDG@disroot.org \
--to=kauschluss@disroot.org \
--cc=andrew.goodbody@linaro.org \
--cc=ansuelsmth@gmail.com \
--cc=bigunclemax@gmail.com \
--cc=chiffathefoxx@gmail.com \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=miquel.raynal@bootlin.com \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox