From: Anshul Dalal <anshuld@ti.com>
To: Yao Zi <me@ziyao.cc>, Peng Fan <peng.fan@nxp.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Tom Rini <trini@konsulko.com>,
Jerome Forissier <jerome.forissier@linaro.org>,
Mattijs Korpershoek <mkorpershoek@kernel.org>
Cc: <u-boot@lists.denx.de>
Subject: Re: [PATCH 0/3] Code improvements and argument checks for mmc dev subcommand
Date: Mon, 2 Feb 2026 13:21:31 +0530 [thread overview]
Message-ID: <DG4B9DIU56WR.1RQ3344R6CL1E@ti.com> (raw)
In-Reply-To: <20260130180353.42205-1-me@ziyao.cc>
On Fri Jan 30, 2026 at 11:33 PM IST, Yao Zi wrote:
> This series reduces code duplication by utilizing fallthrough, then adds
> extra checks for arguments of mmc dev to ensure they're valid numbers,
> preventing unexpected behavior.
>
> The last patch replaces an integer literal returned in do_mmc_dev() by
> its corresponding symbolic constant, CMD_RET_FAILURE to improve
> readability, no function change is involved.
The overall patch series looks good to me, thanks for the cleanup!
Tested-by: Anshul Dalal <anshuld@ti.com>
>
> Yao Zi (3):
> cmd: mmc: Simplify dev subcommand handling
> cmd: mmc: Check whether arguments are valid numbers in dev subcommand
> cmd: mmc: Return symbolic value when part switching fails in mmc dev
>
> cmd/mmc.c | 55 ++++++++++++++++++++++++++++++++-----------------------
> 1 file changed, 32 insertions(+), 23 deletions(-)
next prev parent reply other threads:[~2026-02-02 7:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 18:03 [PATCH 0/3] Code improvements and argument checks for mmc dev subcommand Yao Zi
2026-01-30 18:03 ` [PATCH 1/3] cmd: mmc: Simplify dev subcommand handling Yao Zi
2026-01-30 18:03 ` [PATCH 2/3] cmd: mmc: Check whether arguments are valid numbers in dev subcommand Yao Zi
2026-01-30 18:03 ` [PATCH 3/3] cmd: mmc: Return symbolic value when part switching fails in mmc dev Yao Zi
2026-02-02 7:51 ` Anshul Dalal [this message]
2026-02-03 11:55 ` [PATCH 0/3] Code improvements and argument checks for mmc dev subcommand Peng Fan
2026-02-03 14:18 ` Peng Fan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DG4B9DIU56WR.1RQ3344R6CL1E@ti.com \
--to=anshuld@ti.com \
--cc=jerome.forissier@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=me@ziyao.cc \
--cc=mkorpershoek@kernel.org \
--cc=peng.fan@nxp.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox