Re: [PATCHv2 2/5] efi_dt_fixup: use fdtdec_get_bool

Heinrich Schuchardt
2026-04-09T19:22:20Z

Am 2. April 2026 22:50:35 MESZ schrieb rs@ti.com:
>From: Randolph Sapp <rs@ti.com>
>
>Use the more straightforward fdtdec_get_bool instead of fdt_getprop and
>a return code check.
>
>Signed-off-by: Randolph Sapp <rs@ti.com>

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

>---
> lib/efi_loader/efi_dt_fixup.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/lib/efi_loader/efi_dt_fixup.c b/lib/efi_loader/efi_dt_fixup.c
>index 544e1aa9808..333711b9957 100644
>--- a/lib/efi_loader/efi_dt_fixup.c
>+++ b/lib/efi_loader/efi_dt_fixup.c
>@@ -123,8 +123,7 @@ void efi_carve_out_dt_rsv(void *fdt)
> fdtdec_get_is_enabled(fdt, subnode)) {
> bool nomap;
>
>- nomap = !!fdt_getprop(fdt, subnode, "no-map",
>- NULL);
>+ nomap = fdtdec_get_bool(fdt, subnode, "no-map");
> efi_reserve_memory(fdt_addr, fdt_size, nomap);
> }
> subnode = fdt_next_subnode(fdt, subnode);