From: "Markus Schneider-Pargmann" <msp@baylibre.com>
To: "Maarten Brock" <Maarten.Brock@sttls.nl>,
"Markus Schneider-Pargmann (TI)" <msp@baylibre.com>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Cc: "Jerome Forissier" <jerome.forissier@arm.com>,
"Tom Rini" <trini@konsulko.com>
Subject: Re: [PATCH 2/4] net: cpsw: Remove compat string argument
Date: Tue, 14 Apr 2026 09:01:20 +0200 [thread overview]
Message-ID: <DHSONMPLU5N5.AY9KGH9Z6WFD@baylibre.com> (raw)
In-Reply-To: <GV2PR05MB11941D5BAD20EA6CC43F2C3F783242@GV2PR05MB11941.eurprd05.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
Hi Maarten,
On Mon Apr 13, 2026 at 11:00 AM CEST, Maarten Brock wrote:
> Hi Markus,
>
>> diff --git a/drivers/net/ti/cpsw.c b/drivers/net/ti/cpsw.c index 6bfdbb60091ac1cb7ef5a0bb3ad5221c2c11206f..c844416d50ca3db9bb0d9ffe56cd9c352b8c58b0 100644
>> --- a/drivers/net/ti/cpsw.c
>> +++ b/drivers/net/ti/cpsw.c
>> @@ -1064,9 +1064,10 @@ static void cpsw_gmii_sel_dra7xx(struct cpsw_priv *priv,
>> writel(reg, priv->data->gmii_sel);
>> }
>>
>> -static void cpsw_phy_sel(struct cpsw_priv *priv, const char *compat,
>> - phy_interface_t phy_mode)
>> +static void cpsw_phy_sel(struct cpsw_priv *priv, phy_interface_t
>> +phy_mode)
>
> Indent please. And consider to keep the type on the same line as the parameter.
I think this may have been your mail client? At least in my git patch
and the patch I can see I sent it is all on one line:
+static void cpsw_phy_sel(struct cpsw_priv *priv, phy_interface_t phy_mode)
Best
Markus
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 289 bytes --]
next prev parent reply other threads:[~2026-04-14 7:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 11:04 [PATCH 0/4] net: cpsw: Add cpsw-switch DT binding support Markus Schneider-Pargmann (TI)
2026-04-10 11:04 ` [PATCH 1/4] net: cpsw: Fix error message Markus Schneider-Pargmann (TI)
2026-04-10 11:04 ` [PATCH 2/4] net: cpsw: Remove compat string argument Markus Schneider-Pargmann (TI)
2026-04-13 9:00 ` Maarten Brock
2026-04-14 7:01 ` Markus Schneider-Pargmann [this message]
2026-04-14 8:25 ` Maarten Brock
2026-04-10 11:04 ` [PATCH 3/4] net: cpsw: Use driver data for phy_sel Markus Schneider-Pargmann (TI)
2026-04-13 8:57 ` Maarten Brock
2026-04-14 7:04 ` Markus Schneider-Pargmann
2026-04-10 11:04 ` [PATCH 4/4] net: cpsw: Support new cpsw-switch DT bindings Markus Schneider-Pargmann (TI)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHSONMPLU5N5.AY9KGH9Z6WFD@baylibre.com \
--to=msp@baylibre.com \
--cc=Maarten.Brock@sttls.nl \
--cc=jerome.forissier@arm.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox