Re: [PATCH v5 11/12] dm: core: Split SIMPLE_PM_BUS into phases

["Markus Schneider-Pargmann" <msp@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 2721 bytes --]

Hi Simon,

On Sat Apr 11, 2026 at 4:37 PM CEST, Simon Glass wrote:
> Hi Markus,
>
> On Fri, 10 Apr 2026 at 07:33, Markus Schneider-Pargmann (TI)
> <msp@baylibre.com> wrote:
>>
>> Similar to SIMPLE_BUS, create a SPL_SIMPLE_PM_BUS additional to the
>> SIMPLE_PM_BUS. Most boards will not need SIMPLE_PM_BUS in SPL.
>>
>> This is currently needed to reduce the SPL size for beagle bone black
>> with OF_UPSTREAM enabled.
>>
>> Signed-off-by: Markus Schneider-Pargmann (TI) <msp@baylibre.com>
>> ---
>>  drivers/core/Kconfig  | 8 ++++++++
>>  drivers/core/Makefile | 2 +-
>>  2 files changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
>> index 5419bf65b5d653464f8bf958382ede30954d6402..0471e2977d0a993afcafee11874d43016d6738b4 100644
>> --- a/drivers/core/Kconfig
>> +++ b/drivers/core/Kconfig
>> @@ -342,6 +342,14 @@ config SIMPLE_PM_BUS
>>           Supports the 'simple-pm-bus' driver, which is used for busses that
>>           have power domains and/or clocks which need to be enabled before use.
>>
>> +config SPL_SIMPLE_PM_BUS
>> +       bool "Support simple-pm-bus driver in SPL"
>> +       depends on SPL_DM && SPL_OF_CONTROL && SPL_CLK && SPL_POWER_DOMAIN
>> +       help
>> +         Supports the 'simple-pm-bus' driver, which is used for busses that
>> +         have power domains and/or clocks which need to be enabled before use,
>> +         in SPL.
>> +
>>  config OF_TRANSLATE
>>         bool "Translate addresses using fdt_translate_address"
>>         depends on DM && OF_CONTROL
>> diff --git a/drivers/core/Makefile b/drivers/core/Makefile
>> index a549890c22b997a8c3e7cd6ab08b2ed2ac7994b2..1073c26b2ed0009e15ccca0bac93a64d882f0df9 100644
>> --- a/drivers/core/Makefile
>> +++ b/drivers/core/Makefile
>> @@ -7,7 +7,7 @@ obj-$(CONFIG_$(PHASE_)ACPIGEN) += acpi.o
>>  obj-$(CONFIG_$(PHASE_)DEVRES) += devres.o
>>  obj-$(CONFIG_$(PHASE_)DM_DEVICE_REMOVE)        += device-remove.o
>>  obj-$(CONFIG_$(PHASE_)SIMPLE_BUS)      += simple-bus.o
>> -obj-$(CONFIG_SIMPLE_PM_BUS)    += simple-pm-bus.o
>> +obj-$(CONFIG_$(PHASE_)SIMPLE_PM_BUS)   += simple-pm-bus.o
>>  obj-$(CONFIG_DM)       += dump.o
>>  obj-$(CONFIG_$(PHASE_)REGMAP)  += regmap.o
>>  obj-$(CONFIG_$(PHASE_)SYSCON)  += syscon-uclass.o
>>
>> --
>> 2.53.0
>>
>
> I'm assuming that this doesn't affect any existing boards.

I checked the configs that use SIMPLE_PM_BUS at the moment, I don't
think any of them needs them for SPL. There aren't many and none of them
have SPL_POWER_DOMAIN which would be needed for SIMPLE_PM_BUS to work in
SPL.

>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Thanks for reviewing!

Best
Markus

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 289 bytes --]