U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Anshul Dalal <anshuld@ti.com>
To: Rasmus Villemoes <ravi@prevas.dk>, <u-boot@lists.denx.de>
Cc: Neha Malcom Francis <n-francis@ti.com>,
	Anshul Dalal <anshuld@ti.com>, "Tom Rini" <trini@konsulko.com>,
	Simon Glass <sjg@chromium.org>, <francesco.dolcini@toradex.com>,
	<w.egorov@phytec.de>
Subject: Re: [PATCH 0/6] k3-binman ergonomics
Date: Mon, 13 Jul 2026 17:49:48 +0530	[thread overview]
Message-ID: <DJXFSHTRFW0L.O5673KW71NI8@ti.com> (raw)
In-Reply-To: <20260710123618.2036728-1-ravi@prevas.dk>

On Fri Jul 10, 2026 at 6:06 PM IST, Rasmus Villemoes wrote:
> When trying to hook up use of a customer's own signing infrastructure
> for some am62x devices, I found it was more difficult than it should
> be to point at the right key(s). One has to patch in the keyfile=
> property in way too many places, and if you miss just one, the build
> succeeds using the generic custMpk.pem for the one you missed, but of
> course the resulting artifacts are unbootable.
>

The default value for keyfile i.e custMpk.pem is generated via binman
from the custMpk node in binman (defined in k3-binman.dtsi), modifying
the filepath to your custom key should work as a single line change as
is.

Perhaps this could be made more clear by the use of a macro instead of
hardcoding the string "custMpk.pem" in all the places to make it more
obvious.

Other than that, the addition of configurable distinguished-name could
be valuable addition, do you have any specific use case asides from
downstream boards? I wonder if it could be valuable for existing
upstream platforms from Toradex/Phytec.

CC+: Francesco, Wadim

> Use the template mechanism that binman already has to allow one to
> only set the keyfile= in a single place. I cannot really imagine any
> case where one would not want to use the same key for signing all
> artifacts across the r5/a53 cores, but that is of course still
> possible, just as any downstreams that have explicit
>
> &{/binman/tiboot3-am62x-hs-evm.bin/ti-secure-rom} {
>     keyfile = "foobar.pem";
> };
>
> &{/binman/tiboot3-am62x-hs-fs-evm.bin/ti-secure-rom} {
>     keyfile = "foobar.pem";
> };
>
> will continue to work.
>
> Rasmus Villemoes (6):
>   binman: openssl: refactor creation of Distinguished Name section from
>     dict
>   binman: x509_cert: allow and parse distinguished-name subnode
>   binman: x509: fix CN emitted for basic x509 certificates
>   k3-binman.dtsi: add keyfile_template node
>   k3-binman.dtsi: add empty distinguished_name_template
>   k3-binman.dtsi: insert keyfile and distinguished name templates in all
>     ti-secure(-rom) nodes
>
>  arch/arm/dts/k3-binman.dtsi              | 34 +++++++++++-----
>  tools/binman/btool/openssl.py            | 51 ++++++++----------------
>  tools/binman/etype/ti_secure.py          |  3 +-
>  tools/binman/etype/ti_secure_rom.py      |  3 +-
>  tools/binman/etype/x509_cert.py          |  8 +++-
>  tools/binman/test/security/x509_cert.dts |  5 ++-
>  6 files changed, 55 insertions(+), 49 deletions(-)


  parent reply	other threads:[~2026-07-13 12:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 12:36 [PATCH 0/6] k3-binman ergonomics Rasmus Villemoes
2026-07-10 12:36 ` [PATCH 1/6] binman: openssl: refactor creation of Distinguished Name section from dict Rasmus Villemoes
2026-07-13 12:40   ` Simon Glass
2026-07-14  5:29   ` Neha Malcom Francis
2026-07-10 12:36 ` [PATCH 2/6] binman: x509_cert: allow and parse distinguished-name subnode Rasmus Villemoes
2026-07-13 12:40   ` Simon Glass
2026-07-10 12:36 ` [PATCH 3/6] binman: x509: fix CN emitted for basic x509 certificates Rasmus Villemoes
2026-07-13 12:41   ` Simon Glass
2026-07-10 12:36 ` [PATCH 4/6] k3-binman.dtsi: add keyfile_template node Rasmus Villemoes
2026-07-13 12:41   ` Simon Glass
2026-07-10 12:36 ` [PATCH 5/6] k3-binman.dtsi: add empty distinguished_name_template Rasmus Villemoes
2026-07-13 12:41   ` Simon Glass
2026-07-10 12:36 ` [PATCH 6/6] k3-binman.dtsi: insert keyfile and distinguished name templates in all ti-secure(-rom) nodes Rasmus Villemoes
2026-07-13 12:55   ` Simon Glass
2026-07-13 14:53     ` Rasmus Villemoes
2026-07-13 15:18       ` Simon Glass
2026-07-13 12:19 ` Anshul Dalal [this message]
2026-07-13 12:54   ` [PATCH 0/6] k3-binman ergonomics Rasmus Villemoes
2026-07-14  5:36     ` Anshul Dalal
2026-07-13 12:56 ` [0/6] " Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJXFSHTRFW0L.O5673KW71NI8@ti.com \
    --to=anshuld@ti.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=n-francis@ti.com \
    --cc=ravi@prevas.dk \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=w.egorov@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox