Re: [PATCH] usb: mtu3: wait for TX FIFO to drain before disconnect

["Carlo Caione" <ccaione@baylibre.com>]

On Fri Jul 17, 2026 at 5:21 PM CEST, Marek Vasut wrote:
> On 7/17/26 3:05 PM, Carlo Caione wrote:
>
> [...]
>
>> @@ -66,6 +69,28 @@ static inline void mtu3_ss_func_set(struct mtu3 *mtu, bool enable)
>>   	dev_dbg(mtu->dev, "USB3_EN = %d\n", !!enable);
>>   }
>>   
>> +static void mtu3_wait_for_tx_fifo_empty(struct mtu3 *mtu)
>> +{
>> +	struct mtu3_ep *mep;
>> +	u32 value;
>> +	int ret;
>> +	int i;
>> +
>> +	for (i = 1; i < mtu->num_eps; i++) {
>> +		mep = mtu->in_eps + i;
>> +		if (!(mep->flags & MTU3_EP_ENABLED) ||
>> +		    !list_empty(&mep->req_list))
>> +			continue;
>> +
>> +		ret = readl_poll_timeout(mtu->mac_base + MU3D_EP_TXCR0(i),
>> +					 value, value & TX_FIFOEMPTY,
>> +					 MTU3_TX_FIFO_DRAIN_TIMEOUT_US);
>> +		if (ret)
>> +			dev_warn(mtu->dev, "%s TX FIFO did not drain\n",
>> +				 mep->name);
> Shouldn't there be some interface reset on failure ?

Agree, I'll issue a reset.

> Shouldn't the failure be propagated ?

I'll propagate -ETIMEDOUT in v2.

Thanks,

--
Carlo Caione