From: "Carlo Caione" <ccaione@baylibre.com>
To: "Marek Vasut" <marek.vasut@mailbox.org>,
"Carlo Caione" <ccaione@baylibre.com>,
"GSS_MTK_Uboot_upstream" <GSS_MTK_Uboot_upstream@mediatek.com>,
<u-boot@lists.denx.de>
Cc: "Ryder Lee" <ryder.lee@mediatek.com>,
"Weijie Gao" <weijie.gao@mediatek.com>,
"Chunfeng Yun" <chunfeng.yun@mediatek.com>,
"Igor Belwon" <igor.belwon@mentallysanemainliners.org>,
"David Lechner" <dlechner@baylibre.com>,
"Julien Stephan" <jstephan@baylibre.com>,
"Marek Vasut" <marex@denx.de>, "Tom Rini" <trini@konsulko.com>
Subject: Re: [PATCH v2] usb: mtu3: support the current devicetree binding
Date: Mon, 20 Jul 2026 09:15:03 +0200 [thread overview]
Message-ID: <DK37OZ6BC3H4.3ON0322LPYRB5@baylibre.com> (raw)
In-Reply-To: <1c0aa375-b274-4171-801d-4ee7b857e61e@mailbox.org>
On Sat Jul 18, 2026 at 10:20 PM CEST, Marek Vasut wrote:
> On 7/18/26 12:08 PM, Carlo Caione wrote:
>> @@ -160,13 +167,17 @@ static int get_ssusb_rscs(struct udevice *dev, struct ssusb_mtk *ssusb)
>> return -ENODEV;
>> }
>>
>> - ret = device_find_first_child(dev, &child);
>> - if (ret || !child) {
>> - dev_err(dev, "failed to get child %d!\n", ret);
>> - return ret;
>> + mac_addr = devfdt_get_addr_name(child, "mac");
>
> Use device_*()/ofnode_*() DT accessors please, not the raw
> fdt_*()/devfdt_*() ones.
Agree, I just used what was used before in the same line. I'll fix it.
>> @@ -369,5 +389,6 @@ U_BOOT_DRIVER(mtu3) = {
>> .bind = mtu3_glue_bind,
>> .probe = mtu3_probe,
>> .remove = mtu3_remove,
>> + .plat_auto = sizeof(struct mtu3_glue_plat),
>> .priv_auto = sizeof(struct ssusb_mtk),
>
> Can you extend struct ssusb_mtk with a new field instead of adding plat
> data ?
I don't think ssusb_mtk is available and bind-time. Anyway, I think I
can remove the two variables entirely and just rely on ofnode_equal().
cheers,
--
Carlo Caione
prev parent reply other threads:[~2026-07-20 7:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 10:08 [PATCH v2] usb: mtu3: support the current devicetree binding Carlo Caione
2026-07-18 20:20 ` Marek Vasut
2026-07-20 7:15 ` Carlo Caione [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DK37OZ6BC3H4.3ON0322LPYRB5@baylibre.com \
--to=ccaione@baylibre.com \
--cc=GSS_MTK_Uboot_upstream@mediatek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=dlechner@baylibre.com \
--cc=igor.belwon@mentallysanemainliners.org \
--cc=jstephan@baylibre.com \
--cc=marek.vasut@mailbox.org \
--cc=marex@denx.de \
--cc=ryder.lee@mediatek.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox