public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] PATCH: Add command support for multiple I2C controllers
Date: Thu, 18 May 2006 00:52:07 +0200	[thread overview]
Message-ID: <E1Fgcvi-00075o-UH@mail.sourceforge.net> (raw)
In-Reply-To: Your message of "Wed, 17 May 2006 15:21:35 EDT." <1147893695.16780.239.camel@saruman.qstreams.net>

In message <1147893695.16780.239.camel@saruman.qstreams.net> you wrote:
> 
> Attached is a second stab at a patch to allow access to multiple I2C
> controllers.  It enhances the command set by adding the following
> command, which changes the 'current' I2C bus.  Further write, read,
> probe etc. commands will deal with the newly selected bus:
> 
> ibus [bus_index] [speed in Hz]

No. Please read my posting again. I want to see this as compatible as
possible with other commands that operate  on  devices  connected  to
busses. We use "ide dev ...", so I want to see "i2c dev" here, too.

As mentioned before, in the long term all i2c related commands should
become sub-commands to the new "i2c" command.

> In addition, the logic for ignoring I2C devices during a probe command
> has been enhanced to work with multiple controllers.  The software has
> been tested with new and old configurations (i.e. is backwards
> compatible).
> 
> Old way of ignoring devices:
> 
> #define CFG_I2C_NOPROBES {0x11, 0x22}
> 
> New way:
> 
> #define CFG_I2C_MULTI_NOPROBES {0x11, 0x22, 0xff, 0x33, 0x44, 0xff}

Argh... This is pretty unreadable. Can';t we just  use  an  array  of
lists?


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Things are not as simple as they seem at first.        - Edward Thorp

  reply	other threads:[~2006-05-17 22:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-17 19:21 [U-Boot-Users] PATCH: Add command support for multiple I2C controllers Ben Warren
2006-05-17 22:52 ` Wolfgang Denk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-05-17 23:28 Menon, Nishanth
2006-05-18 14:07 ` Ben Warren
2006-05-18 22:55   ` Wolfgang Denk
2006-05-18  3:03 Menon, Nishanth
     [not found] <20060517225207.3985A3525D9@atlas.denx.de>
2006-05-18 13:51 ` Ben Warren
2006-05-18 16:19   ` Wolfgang Denk
2006-05-18 17:04     ` Ben Warren
2006-05-18 23:03       ` Wolfgang Denk
2006-05-19 12:07         ` Travis B. Sawyer
2006-05-23  6:59           ` Tolunay Orkun
2006-05-19 14:43         ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1Fgcvi-00075o-UH@mail.sourceforge.net \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox