* [U-Boot-Users] Apologies
@ 2006-08-29 18:11 Jon Loeliger
0 siblings, 0 replies; 2+ messages in thread
From: Jon Loeliger @ 2006-08-29 18:11 UTC (permalink / raw)
To: u-boot
Guys,
Apologies for accidental double post problem, there.
jdl
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot-Users] mpc8245 changed from u-boot-1.0.0 to uboot-1.0.2
@ 2004-04-02 18:05 Wolfgang Denk
2004-04-05 20:13 ` Matthew S. McClintock
0 siblings, 1 reply; 2+ messages in thread
From: Wolfgang Denk @ 2004-04-02 18:05 UTC (permalink / raw)
To: u-boot
In message <1080925072.4706.13.camel@sabrina.arlut.utexas.edu> you wrote:
>
> Here is the fix as you requested. But this begs the question, can our
> board specific files change at anytime? And not only be changed but be
> changed into something that does not work?
Actually this can happen any time. It is pretty unlikely, though.
But as maintainer of the U-Boot project I will occasionally decide to
check in patches which may effect board specific code, too.
To perform a global clean-up operations, for example to eliminate
redundand code and replace it by a common implementation like in this
case, I have no other choice but to implement this change everywhere
and for every board. Of course we try to test on as many different
boards as possible, but we cannot test on all boards.
Although never put down in writing I consider it one of the
responsibilities of a board maintainer to check current versions
every now and then - and this definitely means more frequently than
once every three months.
> I can understand changing code in the rest of u-boot and having that
> break our board code, but I don't see the problem with our own board
> code using a depreciated method? Maybe just a note in our board code
Experience has shown that it simply does not work to change the im-
plementation or to provide new interfaces and simpy hope that all
board maintainers will adapt these changes in a resonable time.
Others staring with a new port will are guaranteed to pick up such
old files as model, and continue to use the old stuff.
The only way to get consistent code is to enforce the change for all
boards.
In your case it took nearly 3 months until you even noticed that
something was changed.
> that a certain method is depreciated would be more appropriate? Is there
> another reason I am missing?
Guess how many board maintainers will change working code just
because there is another way to do it?
Sorry, but in my experience this doesn't work.
I apologize for breaking your board.
Now for your patch:
> + /* This code does not work, and needs to be fixed at a later
> + date */
Do you really want me to check this in? I feel you should spend some
more time and fix the code first and submit a new patch then.
Best regards,
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
Swap read error. You lose your mind.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot-Users] mpc8245 changed from u-boot-1.0.0 to uboot-1.0.2
2004-04-02 18:05 [U-Boot-Users] mpc8245 changed from u-boot-1.0.0 to uboot-1.0.2 Wolfgang Denk
@ 2004-04-05 20:13 ` Matthew S. McClintock
2004-04-05 21:13 ` Kodis Babu Janardhanan
0 siblings, 1 reply; 2+ messages in thread
From: Matthew S. McClintock @ 2004-04-05 20:13 UTC (permalink / raw)
To: u-boot
>
>
> Now for your patch:
>
>
> > + /* This code does not work, and needs to be fixed at a later
> > + date */
>
> Do you really want me to check this in? I feel you should spend some
> more time and fix the code first and submit a new patch then.
>
The problem is time, no one has anytime to invest in the problem at the
moment. I've put the marker there so if someone else here needs that
functionality to work they will take the time to fix the problem (and
they will also quickly find what the problem is). I think the advantage
of having the latest u-boot working outweighs the incorrect code at the
moment considering all other factors.
Thanks,
Matthew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-29 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-29 18:11 [U-Boot-Users] Apologies Jon Loeliger
-- strict thread matches above, loose matches on Subject: below --
2004-04-02 18:05 [U-Boot-Users] mpc8245 changed from u-boot-1.0.0 to uboot-1.0.2 Wolfgang Denk
2004-04-05 20:13 ` Matthew S. McClintock
2004-04-05 21:13 ` Kodis Babu Janardhanan
2004-04-05 22:21 ` [U-Boot-Users] Apologies Kodis Babu Janardhanan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox