From: Jon Loeliger <jdl@jdl.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Fix problem with get/setdcr commands introduced by cfg patches
Date: Fri, 06 Jul 2007 08:12:08 -0500 [thread overview]
Message-ID: <E1I6nbU-0000pu-95@jdl.com> (raw)
In-Reply-To: Your message of "Fri, 06 Jul 2007 09:45:47 +0200." <200707060945.47900.sr@denx.de>
So, like, the other day Stefan Roese mumbled:
>
> cpu/ppc4xx/dcr.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/cpu/ppc4xx/dcr.S b/cpu/ppc4xx/dcr.S
> index 7102364..554db1b 100644
> --- a/cpu/ppc4xx/dcr.S
> +++ b/cpu/ppc4xx/dcr.S
> @@ -22,7 +22,7 @@
> */
> #include <config.h>
>
> -#if defined(CONFIG_4xx) && defined(CFG_CMD_SETGETDCR)
> +#if defined(CONFIG_4xx) && ((CONFIG_COMMANDS & CFG_CMD_SETGETDCR) || defined(CONFIG_CMD_SETGETD
> CR))
>
> #include <ppc4xx.h>
Sorry about that.
Hmmm... Something is fishy here if this is a problem...
While the above is a valid (temporary) "fix",
I think rather than re-introducing this clause:
(CONFIG_COMMANDS & CFG_CMD_SETGETDCR)
a better (long term) solution is to try and figure out
why CONFIG_CMD_SETGETDCR isn't available. The goal is
to eliminate the CONFIG_COMMAND symbol, so we should
be able to compile this file without it.
My guesses off the top of my head:
1) I blitzed CONFIG_CMD_SETGETDCR in the 4xx.h config file
2) The 4xx board config file isn't being included here
3) Interaction with a .S file
4) Some secondary #include effect making config_cmd_default.h
be not included
Please let me know if I can further here.
HTH,
jdl
next prev parent reply other threads:[~2007-07-06 13:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-06 7:45 [U-Boot-Users] Fix problem with get/setdcr commands introduced by cfg patches Stefan Roese
2007-07-06 9:02 ` Wolfgang Denk
2007-07-06 13:12 ` Jon Loeliger [this message]
2007-07-06 13:52 ` Stefan Roese
2007-07-06 13:59 ` Jon Loeliger
2007-07-11 10:13 ` [U-Boot-Users] Fix some compile problems introduced by the latest CFG_CMD_xxx cleanup Stefan Roese
2007-07-11 19:22 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1I6nbU-0000pu-95@jdl.com \
--to=jdl@jdl.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox