From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jon Loeliger <jdl@jdl.com>
Date: Fri, 06 Jul 2007 08:12:08 -0500
Subject: [U-Boot-Users] Fix problem with get/setdcr commands introduced
	by cfg patches
In-Reply-To: Your message of "Fri, 06 Jul 2007 09:45:47 +0200."
	<200707060945.47900.sr@denx.de> 
References: <200707060945.47900.sr@denx.de> 
Message-ID: <E1I6nbU-0000pu-95@jdl.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

So, like, the other day Stefan Roese mumbled:
> 
>  cpu/ppc4xx/dcr.S |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/cpu/ppc4xx/dcr.S b/cpu/ppc4xx/dcr.S
> index 7102364..554db1b 100644
> --- a/cpu/ppc4xx/dcr.S
> +++ b/cpu/ppc4xx/dcr.S
> @@ -22,7 +22,7 @@
>   */
>  #include <config.h>
>  
> -#if defined(CONFIG_4xx) && defined(CFG_CMD_SETGETDCR)
> +#if defined(CONFIG_4xx) && ((CONFIG_COMMANDS & CFG_CMD_SETGETDCR) || defined(CONFIG_CMD_SETGETD
> CR))
>  
>  #include <ppc4xx.h>

Sorry about that.

Hmmm... Something is fishy here if this is a problem...

While the above is a valid (temporary) "fix",
I think rather than re-introducing this clause:

    (CONFIG_COMMANDS & CFG_CMD_SETGETDCR)

a better (long term) solution is to try and figure out
why CONFIG_CMD_SETGETDCR isn't available.  The goal is
to eliminate the CONFIG_COMMAND symbol, so we should
be able to compile this file without it.

My guesses off the top of my head:

    1) I blitzed CONFIG_CMD_SETGETDCR in the 4xx.h config file
    2) The 4xx board config file isn't being included here
    3) Interaction with a .S file
    4) Some secondary #include effect making config_cmd_default.h
       be not included

Please let me know if I can further here.

HTH,
jdl