public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@jdl.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Fix problem with get/setdcr commands introduced by cfg patches
Date: Fri, 06 Jul 2007 08:59:53 -0500	[thread overview]
Message-ID: <E1I6oLh-0000yS-TC@jdl.com> (raw)
In-Reply-To: Your message of "Fri, 06 Jul 2007 15:52:33 +0200." <200707061552.33717.sr@denx.de>

So, like, the other day Stefan Roese mumbled:
> 
> I have no problems with just using:
> 
> #if defined(CONFIG_4xx) && defined(CONFIG_CMD_SETGETDCR)
> 
> here. But we had:
> 
> #if defined(CONFIG_4xx) && defined(CFG_CMD_SETGETDCR)

D'oh.  That's just my brain-damage and late night drinking. :-)

You are in a twisty maze of #defines all alike...

> So this couldn't work.

I'll bet not...

> Feel free to clean this up with your next patchset.

Will do!

jdl

  reply	other threads:[~2007-07-06 13:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-06  7:45 [U-Boot-Users] Fix problem with get/setdcr commands introduced by cfg patches Stefan Roese
2007-07-06  9:02 ` Wolfgang Denk
2007-07-06 13:12 ` Jon Loeliger
2007-07-06 13:52   ` Stefan Roese
2007-07-06 13:59     ` Jon Loeliger [this message]
2007-07-11 10:13 ` [U-Boot-Users] Fix some compile problems introduced by the latest CFG_CMD_xxx cleanup Stefan Roese
2007-07-11 19:22   ` Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1I6oLh-0000yS-TC@jdl.com \
    --to=jdl@jdl.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox