From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: fix a build error with CONFIG_USE_IRQ
Date: Mon, 9 Jun 2014 10:35:06 +0200 [thread overview]
Message-ID: <E1Wtv2q-0005ZL-4J@janus> (raw)
In-Reply-To: <20140609163656.95BE.AA925319@jp.panasonic.com>
Hi Masahiro,
On Mon, 09 Jun 2014 16:36:56 +0900, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:
> Hi Albert,
>
> On Mon, 9 Jun 2014 09:14:11 +0200
> Albert ARIBAUD <albert.u.boot@aribaud.net> wrote:
>
> > Hi Masahiro,
> >
> > On Mon, 26 May 2014 19:43:50 +0900, Masahiro Yamada
> > <yamada.m@jp.panasonic.com> wrote:
> >
> > > Commit 41623c91 moved exception handling to arch/arm/lib/vectors.S,
> > > breaking CONFIG_USE_IRQ feature.
> > >
> > > If CONFIG_USE_IRQ is enabled, undefined reference error occurs.
> > >
> > > arch/arm/lib/built-in.o: In function `interrupt_init':
> > > arch/arm/lib/interrupts.c:37: undefined reference to `IRQ_STACK_START'
> > > arch/arm/lib/interrupts.c:37: undefined reference to `FIQ_STACK_START'
> > > make: *** [u-boot] Error 1
> > >
> > > Because arch/arm/lib/vectors.S includes references to
> > > CONFIG_SYS_DV_NOR_BOOT_CFG and CONFIG_USE_IRQ, it must include <config.h>.
> >
> > I routinely build all of ARM (32-bit) and AARCH64 (64-bit) targets and
> > make sure all of them build properly, and concerning CONFIG_USE_IRQ, I
> > even have a branch set to remove this option since a
> >
> > git grep CONFIG_USE_IRQ | grep -vE \
> > '(#define|#ifdef|#ifndef|#if.*defined|#undef|#endif)'
> >
> > shows that it is defined nowhere in our code.
> >
> > Which source code are you using?
>
> Out-of-tree board support code, maintained locally.
Then I'm afraid you'll have to keep this patch local too -- and note
that I am considering overhauling, and possibly removing entirely,
CONFIG_USE_IRQ (my grep command comes from my WIP on this).
> Best Regards
> Masahiro Yamada
Amicalement,
--
Albert.
next prev parent reply other threads:[~2014-06-09 8:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 10:43 [U-Boot] [PATCH] arm: fix a build error with CONFIG_USE_IRQ Masahiro Yamada
2014-06-09 7:14 ` Albert ARIBAUD
2014-06-09 7:36 ` Masahiro Yamada
2014-06-09 8:35 ` Albert ARIBAUD [this message]
2014-06-09 9:29 ` Masahiro Yamada
2014-06-09 9:42 ` Albert ARIBAUD
2014-06-09 11:19 ` Masahiro Yamada
2014-06-11 7:14 ` [U-Boot] enbw_cmc, da850evm_direct_nor, and calimain vectors table misaligned (was: [PATCH] arm: fix a build error with CONFIG_USE_IRQ) Albert ARIBAUD
2014-06-11 7:47 ` [U-Boot] enbw_cmc, da850evm_direct_nor, and calimain vectors table misaligned Heiko Schocher
2014-06-11 13:15 ` Christian Riesch
2014-06-12 8:05 ` Christian Riesch
2014-06-13 7:46 ` [U-Boot] enbw_cmc, da850evm_direct_nor, and calimain vectors table misaligned (was: [PATCH] arm: fix a build error with CONFIG_USE_IRQ) Masahiro Yamada
2014-06-18 12:55 ` Christian Riesch
2014-06-18 13:08 ` Christian Riesch
2014-07-02 13:45 ` Christian Riesch
2014-07-04 20:35 ` Albert ARIBAUD
2014-07-07 7:15 ` Christian Riesch
2014-07-07 8:55 ` Christian Riesch
2014-06-09 11:18 ` [U-Boot] [PATCH] arm: fix a build error with CONFIG_USE_IRQ Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Wtv2q-0005ZL-4J@janus \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox