From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: fix a double-definition error of _start symbol
Date: Mon, 9 Jun 2014 10:40:59 +0200 [thread overview]
Message-ID: <E1Wtv8W-0005by-Al@janus> (raw)
In-Reply-To: <1401156989-6997-1-git-send-email-yamada.m@jp.panasonic.com>
Hi Masahiro,
On Tue, 27 May 2014 11:16:29 +0900, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:
> The symbol "_start" is defined twice in arch/arm/lib/vectors.S:
> around line 48 and line 54.
>
> If CONFIG_SYS_DV_NOR_BOOT_CFG is defined (as on calimain board),
> build fails:
>
> arch/arm/lib/vectors.S: Assembler messages:
> arch/arm/lib/vectors.S:54: Error: symbol `_start' is already defined
> make[1]: *** [arch/arm/lib/vectors.o] Error 1
> make: *** [arch/arm/lib] Error 2
Apart from the shame of having written this double definition myself and
missed it entirely, I am surprised because this error (obviously) does
not occur on my setup. Which toolchain are you using?
Anyway:
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
> arch/arm/lib/vectors.S | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
> index fad00da..493f337 100644
> --- a/arch/arm/lib/vectors.S
> +++ b/arch/arm/lib/vectors.S
> @@ -45,8 +45,6 @@
> *************************************************************************
> */
>
> -_start:
> -
> #ifdef CONFIG_SYS_DV_NOR_BOOT_CFG
> .word CONFIG_SYS_DV_NOR_BOOT_CFG
> #endif
Applied to u-boot-arm/master, thanks!
Amicalement,
--
Albert.
next prev parent reply other threads:[~2014-06-09 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 2:16 [U-Boot] [PATCH] arm: fix a double-definition error of _start symbol Masahiro Yamada
2014-06-09 8:40 ` Albert ARIBAUD [this message]
2014-06-09 9:44 ` Masahiro Yamada
2014-06-09 9:58 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Wtv8W-0005by-Al@janus \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox