From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Mon, 9 Jun 2014 10:40:59 +0200
Subject: [U-Boot] [PATCH] arm: fix a double-definition error of _start
	symbol
In-Reply-To: <1401156989-6997-1-git-send-email-yamada.m@jp.panasonic.com>
References: <1401156989-6997-1-git-send-email-yamada.m@jp.panasonic.com>
Message-ID: <E1Wtv8W-0005by-Al@janus>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Masahiro,

On Tue, 27 May 2014 11:16:29 +0900, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:

> The symbol "_start" is defined twice in arch/arm/lib/vectors.S:
> around line 48 and line 54.
> 
> If CONFIG_SYS_DV_NOR_BOOT_CFG is defined (as on calimain board),
> build fails:
> 
>   arch/arm/lib/vectors.S: Assembler messages:
>   arch/arm/lib/vectors.S:54: Error: symbol `_start' is already defined
>   make[1]: *** [arch/arm/lib/vectors.o] Error 1
>   make: *** [arch/arm/lib] Error 2

Apart from the shame of having written this double definition myself and
missed it entirely, I am surprised because this error (obviously) does
not occur on my setup. Which toolchain are you using?

Anyway:

> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
>  arch/arm/lib/vectors.S | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
> index fad00da..493f337 100644
> --- a/arch/arm/lib/vectors.S
> +++ b/arch/arm/lib/vectors.S
> @@ -45,8 +45,6 @@
>   *************************************************************************
>   */
>  
> -_start:
> -
>  #ifdef CONFIG_SYS_DV_NOR_BOOT_CFG
>  	.word	CONFIG_SYS_DV_NOR_BOOT_CFG
>  #endif

Applied to u-boot-arm/master, thanks!

Amicalement,
-- 
Albert.