From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] socfpga: Relocate arch common functions away from board
Date: Tue, 10 Jun 2014 09:07:56 +0200 [thread overview]
Message-ID: <E1WuGA1-0003K0-TC@janus> (raw)
In-Reply-To: <1402382467-3213-1-git-send-email-clsee@altera.com>
Hi Chin,
On Tue, 10 Jun 2014 01:41:06 -0500, Chin Liang See <clsee@altera.com>
wrote:
> To move the arch common function away from board folder to
> arch/arm/cpu/armv7/socfpga folder.
>
> Signed-off-by: Chin Liang See <clsee@altera.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Detlev Zundel <dzu@denx.de>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> ---
> arch/arm/cpu/armv7/socfpga/misc.c | 24 ++++++++++++++++++++++++
> board/altera/socfpga/socfpga_cyclone5.c | 23 -----------------------
> 2 files changed, 24 insertions(+), 23 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/socfpga/misc.c b/arch/arm/cpu/armv7/socfpga/misc.c
> index 2f1c716..5268f2c 100644
> --- a/arch/arm/cpu/armv7/socfpga/misc.c
> +++ b/arch/arm/cpu/armv7/socfpga/misc.c
> @@ -14,3 +14,27 @@ int dram_init(void)
> gd->ram_size = get_ram_size((long *)PHYS_SDRAM_1, PHYS_SDRAM_1_SIZE);
> return 0;
> }
> +
> +#if defined(CONFIG_DISPLAY_CPUINFO)
> +/*
> + * Print CPU information
> + */
> +int print_cpuinfo(void)
> +{
> + puts("CPU : Altera SOCFPGA Platform\n");
> + return 0;
> +}
> +#endif
> +
> +#if defined(CONFIG_SYS_CONSOLE_IS_IN_ENV) && \
> +defined(CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE)
> +int overwrite_console(void)
> +{
> + return 0;
> +}
> +#endif
> +
> +int misc_init_r(void)
> +{
> + return 0;
> +}
> diff --git a/board/altera/socfpga/socfpga_cyclone5.c b/board/altera/socfpga/socfpga_cyclone5.c
> index a960eb6..f366565 100644
> --- a/board/altera/socfpga/socfpga_cyclone5.c
> +++ b/board/altera/socfpga/socfpga_cyclone5.c
> @@ -12,17 +12,6 @@
>
> DECLARE_GLOBAL_DATA_PTR;
>
> -#if defined(CONFIG_DISPLAY_CPUINFO)
> -/*
> - * Print CPU information
> - */
> -int print_cpuinfo(void)
> -{
> - puts("CPU : Altera SOCFPGA Platform\n");
> - return 0;
> -}
> -#endif
> -
> /*
> * Print Board information
> */
> @@ -49,18 +38,6 @@ int board_init(void)
> return 0;
> }
>
> -int misc_init_r(void)
> -{
> - return 0;
> -}
> -
> -#if defined(CONFIG_SYS_CONSOLE_IS_IN_ENV) && defined(CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE)
> -int overwrite_console(void)
> -{
> - return 0;
> -}
> -#endif
> -
> /*
> * DesignWare Ethernet initialization
> */
Can you clarify in the commit message why this change is needed or
useful?
Amicalement,
--
Albert.
next prev parent reply other threads:[~2014-06-10 7:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 6:41 [U-Boot] [PATCH] socfpga: Relocate arch common functions away from board Chin Liang See
2014-06-10 7:07 ` Albert ARIBAUD [this message]
2014-06-10 7:19 ` Chin Liang See
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1WuGA1-0003K0-TC@janus \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox