From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sat, 5 Jul 2014 11:13:59 +0200 Subject: [U-Boot] [PATCH] ARM:asm:io.h use static inline In-Reply-To: <1403471439-23370-1-git-send-email-jeroen@myspectrum.nl> References: <1403471439-23370-1-git-send-email-jeroen@myspectrum.nl> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Jeroen, On Sun, 22 Jun 2014 23:10:39 +0200, Jeroen Hofstee wrote: > When compiling u-boot with W=1 the extern inline void for > read* is likely causing the most noise. gcc / clang will > warn there is never a actual declaration for these functions. > Instead of declaring these extern make them static inline so > it is actually declared. > > cc: Albert ARIBAUD > Signed-off-by: Jeroen Hofstee > --- Ok, so the obvious question: what makes you decide to switch to 'static inline' rather than provide the extern versions that 'extern static' calls for? (see e.g. http://elinux.org/Extern_Vs_Static_Inline for an example discussion on 'static inline' vs 'extern inline'. Note: this link is not intended as an expression of my stance on the issue, as I don't have any.) Amicalement, -- Albert.