From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Fri, 19 Sep 2014 17:56:10 +0200
Subject: [U-Boot] [PATCH 6/7] arm: ls102xa: Add SD boot support for
 LS1021AQDS board
In-Reply-To: <1411053355745.66856@freescale.com>
References: <1411019239-12360-1-git-send-email-b18965@freescale.com>
	<1411019239-12360-7-git-send-email-b18965@freescale.com>
	<E1XUZlT-0002q6-QZ@janus> <1411053355745.66856@freescale.com>
Message-ID: <E1XV0Xb-0002D2-KV@janus>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Huan,

On Thu, 18 Sep 2014 15:15:54 +0000, Huan Wang
<alison.wang@freescale.com> wrote:

> Hi, Albert,
> 
> On Thu, 18 Sep 2014 13:47:18 +0800, Alison Wang <b18965@freescale.com>
> wrote:
> 
> > +
> > +     . = ALIGN(4);
> > +     .u_boot_list : {
> > +             KEEP(*(SORT(.u_boot_list*_i2c_*)));
> > +     }
> 
> IS this required? And if it is, could it not be added to the
> arch/arm/cpu/u-boot-spl.lds file? This way you would not need an .lds
> file at all.
> 
> [Alison Wang] Yes, it is required.

Ok -- what for? :)

> I would like to add it in arch/arm/cpu/u-boot-spl.lds. I was not sure
> adding it in arch/arm/cpu/u-boot-spl.lds is acceptable or not.

(assuming the reason why it is needed is valid) If it causes no change
to boards which do not use it right now (and I mean 'no change' ad
'binary identical') then this is acceptable. Make sure you check the
binary invariance and that you mention it in the commit.

> Best Regards,
> Alison Wang

Amicalement,
-- 
Albert.