From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Sat, 11 Oct 2014 10:56:47 +0200
Subject: [U-Boot] [PATCH 2/2] kconfig: add CONFIG_SUPPORT_TPL
In-Reply-To: <1411636747-10276-3-git-send-email-yamada.m@jp.panasonic.com>
References: <1411636747-10276-1-git-send-email-yamada.m@jp.panasonic.com>
	<1411636747-10276-3-git-send-email-yamada.m@jp.panasonic.com>
Message-ID: <E1XcsTo-0007rL-Ob@janus>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Masahiro,

On Thu, 25 Sep 2014 18:19:07 +0900, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:

> CONFIG_TPL should not be enabled for boards that do not have TPL.
> CONFIG_SUPPORT_TPL introduced by this commit should be "select"ed
> by boards with TPL support and CONFIG_TPL should depend on it.

Actually, I see no CONFIG_SUPPORT_TPL in the patch, only
HAVE_TPL_SUPPORT. The commit message should match the patch content on
this point, should it not?

> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> 
>  Kconfig                          | 5 ++++-
>  arch/powerpc/cpu/mpc85xx/Kconfig | 5 +++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/Kconfig b/Kconfig
> index 29e0b92..0b9be50 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -73,6 +73,9 @@ config TPL_BUILD
>  config SUPPORT_SPL
>  	bool
>  
> +config HAVE_TPL_SUPPORT
> +	bool
> +
>  config SPL
>  	bool
>  	depends on SUPPORT_SPL
> @@ -83,7 +86,7 @@ config SPL
>  
>  config TPL
>  	bool
> -	depends on SPL
> +	depends on SPL && HAVE_TPL_SUPPORT
>  	prompt "Enable TPL" if !SPL_BUILD
>  	default y if TPL_BUILD
>  	default n
> diff --git a/arch/powerpc/cpu/mpc85xx/Kconfig b/arch/powerpc/cpu/mpc85xx/Kconfig
> index 6dcc45a..c5ebd40 100644
> --- a/arch/powerpc/cpu/mpc85xx/Kconfig
> +++ b/arch/powerpc/cpu/mpc85xx/Kconfig
> @@ -31,6 +31,7 @@ config TARGET_BSC9132QDS
>  config TARGET_C29XPCIE
>  	bool "Support C29XPCIE"
>  	select SUPPORT_SPL
> +	select SUPPORT_TPL
>  
>  config TARGET_P3041DS
>  	bool "Support P3041DS"
> @@ -77,10 +78,12 @@ config TARGET_MPC8572DS
>  config TARGET_P1010RDB
>  	bool "Support P1010RDB"
>  	select SUPPORT_SPL
> +	select SUPPORT_TPL
>  
>  config TARGET_P1022DS
>  	bool "Support P1022DS"
>  	select SUPPORT_SPL
> +	select SUPPORT_TPL
>  
>  config TARGET_P1023RDB
>  	bool "Support P1023RDB"
> @@ -88,10 +91,12 @@ config TARGET_P1023RDB
>  config TARGET_P1_P2_RDB
>  	bool "Support P1_P2_RDB"
>  	select SUPPORT_SPL
> +	select SUPPORT_TPL
>  
>  config TARGET_P1_P2_RDB_PC
>  	bool "Support p1_p2_rdb_pc"
>  	select SUPPORT_SPL
> +	select SUPPORT_TPL
>  
>  config TARGET_P1_TWR
>  	bool "Support p1_twr"


Amicalement,
-- 
Albert.