From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] ARM: prevent compiler warnings from bootm.c
Date: Sat, 11 Oct 2014 12:52:22 +0200 [thread overview]
Message-ID: <E1XcuHf-0008MX-Jd@janus> (raw)
In-Reply-To: <1412116804-31677-2-git-send-email-eric.nelson@boundarydevices.com>
Hi Eric,
On Tue, 30 Sep 2014 15:40:01 -0700, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
> Without preceding declarations, "make C=1" generates
> "Should it be static?" warnings for symbols
> do_bootm_linux,
> boot_prep_vxworks, and
> boot_jump_vxworks
>
> Include of bootm.h also identified a signature mismatch
> (const on argv[]).
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> arch/arm/lib/bootm.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
> index 39fe7a1..4949d57 100644
> --- a/arch/arm/lib/bootm.c
> +++ b/arch/arm/lib/bootm.c
> @@ -22,6 +22,8 @@
> #include <asm/bootm.h>
> #include <asm/secure.h>
> #include <linux/compiler.h>
> +#include <bootm.h>
> +#include <vxworks.h>
>
> #if defined(CONFIG_ARMV7_NONSEC) || defined(CONFIG_ARMV7_VIRT)
> #include <asm/armv7.h>
> @@ -299,7 +301,8 @@ static void boot_jump_linux(bootm_headers_t *images, int flag)
> * DIFFERENCE: Instead of calling prep and go at the end
> * they are called if subcommand is equal 0.
> */
> -int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images)
> +int do_bootm_linux(int flag, int argc, char * const argv[],
> + bootm_headers_t *images)
> {
> /* No need for those on ARM */
> if (flag & BOOTM_STATE_OS_BD_T || flag & BOOTM_STATE_OS_CMDLINE)
Acked-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
Amicalement,
--
Albert.
next prev parent reply other threads:[~2014-10-11 10:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 22:40 [U-Boot] [PATCH 0/4] ARM: clean up declarations of public functions Eric Nelson
2014-09-30 22:40 ` [U-Boot] [PATCH 1/4] ARM: prevent compiler warnings from bootm.c Eric Nelson
2014-10-11 10:52 ` Albert ARIBAUD [this message]
2014-10-21 8:50 ` Stefano Babic
2014-09-30 22:40 ` [U-Boot] [PATCH 2/4] ARM: i.MX6: include prototype for get_board_rev() Eric Nelson
2014-10-21 8:50 ` Stefano Babic
2014-09-30 22:40 ` [U-Boot] [PATCH 3/4] ARM: i.MX: provide declaration for board_spi_cs_gpio Eric Nelson
2014-10-21 8:51 ` Stefano Babic
2014-09-30 22:40 ` [U-Boot] [PATCH 4/4] ARM: i.MX video: declare displays and display_count publicly Eric Nelson
2014-10-21 8:51 ` Stefano Babic
2014-09-30 23:01 ` [U-Boot] [PATCH] stdio: staticize locally-used call-backs Eric Nelson
2014-10-27 22:19 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1XcuHf-0008MX-Jd@janus \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox