[U-Boot] [PATCH 6/7] arm: ls102xa: Add SD boot support for LS1021AQDS board

Albert ARIBAUD
2014-09-19T15:56:10Z

Hi Huan,

On Thu, 18 Sep 2014 15:15:54 +0000, Huan Wang
<alison.wang@freescale.com> wrote:

> Hi, Albert,
>
> On Thu, 18 Sep 2014 13:47:18 +0800, Alison Wang <b18965@freescale.com>
> wrote:
>
> > +
> > + . = ALIGN(4);
> > + .u_boot_list : {
> > + KEEP(*(SORT(.u_boot_list*_i2c_*)));
> > + }
>
> IS this required? And if it is, could it not be added to the
> arch/arm/cpu/u-boot-spl.lds file? This way you would not need an .lds
> file at all.
>
> [Alison Wang] Yes, it is required.

Ok -- what for? :)

> I would like to add it in arch/arm/cpu/u-boot-spl.lds. I was not sure
> adding it in arch/arm/cpu/u-boot-spl.lds is acceptable or not.

(assuming the reason why it is needed is valid) If it causes no change
to boards which do not use it right now (and I mean 'no change' ad
'binary identical') then this is acceptable. Make sure you check the
binary invariance and that you mention it in the commit.

> Best Regards,
> Alison Wang

Amicalement,
--
Albert.