[U-Boot] [OT] Re: [PATCH 2/7] ls102xa: pblimage: Add pblimage tool support for LS102xA

Huan Wang
2014-09-24T08:00:39Z

Hi, Albert,

> On Mon, 22 Sep 2014 06:22:44 +0000, Huan Wang
> <alison.wang@freescale.com> wrote:
>
> > Hi, Albert,
> >
> > > On Thu, 18 Sep 2014 13:47:14 +0800, Alison Wang
> > > <b18965@freescale.com>
> > > wrote:
> > >
> > > > @@ -111,6 +115,14 @@ static void pbl_parser(char *name)
> > > > size_t len = 0;
> > > >
> > > > fname = name;
> > > > +
> > > > + if (strstr(fname, "ls102xa")) {
> > > > + next_pbl_cmd = 0x8101a000;
> > > > + pbl_cmd_initaddr = 0x8101a000;
> > > > + pbi_crc_cmd1 = 0x61;
> > > > + pbi_crc_cmd2 = 0;
> > > > + }
> > >
> > > Basing the tool's behaviour on the file name is not a good approach
> IMO.
> > > Can't we add some command line option to the tool to select the
> > > right set of values?
> >
> > [Alison Wang] Yes, it is really not a good approach. How about this
> command line approach?
> >
> > [copy-paste of a diff follows]
>
> Please do not paste entire diffs in mails to the U-Boot Mailing list
> unless you are actually submitting them as a patch. When Patchwork sees
> a diff in a mail, it creates a new patch entry. Here, your diff made
> Patchwork create a second entry for patch 2/7 at
>
> <http://patchwork.ozlabs.org/patch/391796/>
>
> I have manually marked it as "Not Applicable".
>
[Alison Wang] Sorry. Thanks for the reminder.

Best Regards,
Alison Wang