* [U-Boot] [RESEND PATCH 1/6] rockchip: clk: rk3399: Convert to livetree
2017-09-12 15:32 [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7 Philipp Tomsich
@ 2017-09-12 15:32 ` Philipp Tomsich
2017-09-13 4:26 ` Simon Glass
2017-09-13 10:29 ` [U-Boot] [U-Boot, RESEND, " Philipp Tomsich
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 2/6] rockchip: xhci: " Philipp Tomsich
` (5 subsequent siblings)
6 siblings, 2 replies; 23+ messages in thread
From: Philipp Tomsich @ 2017-09-12 15:32 UTC (permalink / raw)
To: u-boot
Update the clock driver for the RK3399 to support a live device tree.
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---
drivers/clk/rockchip/clk_rk3399.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/rockchip/clk_rk3399.c b/drivers/clk/rockchip/clk_rk3399.c
index 3edafea..04f0b3f 100644
--- a/drivers/clk/rockchip/clk_rk3399.c
+++ b/drivers/clk/rockchip/clk_rk3399.c
@@ -975,7 +975,7 @@ static int rk3399_clk_ofdata_to_platdata(struct udevice *dev)
#if !CONFIG_IS_ENABLED(OF_PLATDATA)
struct rk3399_clk_priv *priv = dev_get_priv(dev);
- priv->cru = (struct rk3399_cru *)devfdt_get_addr(dev);
+ priv->cru = dev_read_addr_ptr(dev);
#endif
return 0;
}
@@ -1159,7 +1159,7 @@ static int rk3399_pmuclk_ofdata_to_platdata(struct udevice *dev)
#if !CONFIG_IS_ENABLED(OF_PLATDATA)
struct rk3399_pmuclk_priv *priv = dev_get_priv(dev);
- priv->pmucru = (struct rk3399_pmucru *)devfdt_get_addr(dev);
+ priv->pmucru = dev_read_addr_ptr(dev);
#endif
return 0;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 23+ messages in thread* [U-Boot] [RESEND PATCH 1/6] rockchip: clk: rk3399: Convert to livetree
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 1/6] rockchip: clk: rk3399: Convert to livetree Philipp Tomsich
@ 2017-09-13 4:26 ` Simon Glass
2017-09-13 10:29 ` [U-Boot] [U-Boot, RESEND, " Philipp Tomsich
1 sibling, 0 replies; 23+ messages in thread
From: Simon Glass @ 2017-09-13 4:26 UTC (permalink / raw)
To: u-boot
On 12 September 2017 at 09:32, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> Update the clock driver for the RK3399 to support a live device tree.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>
> drivers/clk/rockchip/clk_rk3399.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 23+ messages in thread
* [U-Boot] [U-Boot, RESEND, 1/6] rockchip: clk: rk3399: Convert to livetree
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 1/6] rockchip: clk: rk3399: Convert to livetree Philipp Tomsich
2017-09-13 4:26 ` Simon Glass
@ 2017-09-13 10:29 ` Philipp Tomsich
1 sibling, 0 replies; 23+ messages in thread
From: Philipp Tomsich @ 2017-09-13 10:29 UTC (permalink / raw)
To: u-boot
> Update the clock driver for the RK3399 to support a live device tree.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>
> drivers/clk/rockchip/clk_rk3399.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied to u-boot-rockchip, thanks!
^ permalink raw reply [flat|nested] 23+ messages in thread
* [U-Boot] [RESEND PATCH 2/6] rockchip: xhci: Convert to livetree
2017-09-12 15:32 [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7 Philipp Tomsich
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 1/6] rockchip: clk: rk3399: Convert to livetree Philipp Tomsich
@ 2017-09-12 15:32 ` Philipp Tomsich
2017-09-13 4:26 ` Simon Glass
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 3/6] rockchip: efuse: change to use dev_read_addr_ptr Philipp Tomsich
` (4 subsequent siblings)
6 siblings, 1 reply; 23+ messages in thread
From: Philipp Tomsich @ 2017-09-12 15:32 UTC (permalink / raw)
To: u-boot
Update the Rockchip xhci wrapper driver to support a live device tree.
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---
drivers/usb/host/xhci-rockchip.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/host/xhci-rockchip.c b/drivers/usb/host/xhci-rockchip.c
index ec55f4e..ca3abff 100644
--- a/drivers/usb/host/xhci-rockchip.c
+++ b/drivers/usb/host/xhci-rockchip.c
@@ -6,8 +6,6 @@
*/
#include <common.h>
#include <dm.h>
-#include <fdtdec.h>
-#include <libfdt.h>
#include <malloc.h>
#include <usb.h>
#include <watchdog.h>
@@ -46,7 +44,7 @@ static int xhci_usb_ofdata_to_platdata(struct udevice *dev)
/*
* Get the base address for XHCI controller from the device node
*/
- plat->hcd_base = devfdt_get_addr(dev);
+ plat->hcd_base = dev_read_addr(dev);
if (plat->hcd_base == FDT_ADDR_T_NONE) {
error("Can't get the XHCI register base address\n");
return -ENXIO;
--
2.1.4
^ permalink raw reply related [flat|nested] 23+ messages in thread* [U-Boot] [RESEND PATCH 3/6] rockchip: efuse: change to use dev_read_addr_ptr
2017-09-12 15:32 [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7 Philipp Tomsich
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 1/6] rockchip: clk: rk3399: Convert to livetree Philipp Tomsich
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 2/6] rockchip: xhci: " Philipp Tomsich
@ 2017-09-12 15:32 ` Philipp Tomsich
2017-09-13 4:26 ` Simon Glass
2017-09-13 10:29 ` [U-Boot] [U-Boot, RESEND, " Philipp Tomsich
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 4/6] usb: dwc2: convert to livetree Philipp Tomsich
` (3 subsequent siblings)
6 siblings, 2 replies; 23+ messages in thread
From: Philipp Tomsich @ 2017-09-12 15:32 UTC (permalink / raw)
To: u-boot
With the dev_read_addr_ptr function available, we can change the
efuse driver to use it (and eliminate the explicit type-cast).
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---
drivers/misc/rockchip-efuse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/rockchip-efuse.c b/drivers/misc/rockchip-efuse.c
index 2e3bc91..a2203bf 100644
--- a/drivers/misc/rockchip-efuse.c
+++ b/drivers/misc/rockchip-efuse.c
@@ -142,7 +142,7 @@ static int rockchip_efuse_ofdata_to_platdata(struct udevice *dev)
{
struct rockchip_efuse_platdata *plat = dev_get_platdata(dev);
- plat->base = (void *)dev_read_addr(dev);
+ plat->base = dev_read_addr_ptr(dev);
return 0;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 23+ messages in thread* [U-Boot] [RESEND PATCH 3/6] rockchip: efuse: change to use dev_read_addr_ptr
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 3/6] rockchip: efuse: change to use dev_read_addr_ptr Philipp Tomsich
@ 2017-09-13 4:26 ` Simon Glass
2017-09-13 10:29 ` [U-Boot] [U-Boot, RESEND, " Philipp Tomsich
1 sibling, 0 replies; 23+ messages in thread
From: Simon Glass @ 2017-09-13 4:26 UTC (permalink / raw)
To: u-boot
On 12 September 2017 at 09:32, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> With the dev_read_addr_ptr function available, we can change the
> efuse driver to use it (and eliminate the explicit type-cast).
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>
> drivers/misc/rockchip-efuse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 23+ messages in thread
* [U-Boot] [U-Boot, RESEND, 3/6] rockchip: efuse: change to use dev_read_addr_ptr
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 3/6] rockchip: efuse: change to use dev_read_addr_ptr Philipp Tomsich
2017-09-13 4:26 ` Simon Glass
@ 2017-09-13 10:29 ` Philipp Tomsich
1 sibling, 0 replies; 23+ messages in thread
From: Philipp Tomsich @ 2017-09-13 10:29 UTC (permalink / raw)
To: u-boot
> With the dev_read_addr_ptr function available, we can change the
> efuse driver to use it (and eliminate the explicit type-cast).
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>
> drivers/misc/rockchip-efuse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied to u-boot-rockchip, thanks!
^ permalink raw reply [flat|nested] 23+ messages in thread
* [U-Boot] [RESEND PATCH 4/6] usb: dwc2: convert to livetree
2017-09-12 15:32 [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7 Philipp Tomsich
` (2 preceding siblings ...)
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 3/6] rockchip: efuse: change to use dev_read_addr_ptr Philipp Tomsich
@ 2017-09-12 15:32 ` Philipp Tomsich
2017-09-13 4:27 ` Simon Glass
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 5/6] usb: host: ehci-generic: " Philipp Tomsich
` (2 subsequent siblings)
6 siblings, 1 reply; 23+ messages in thread
From: Philipp Tomsich @ 2017-09-12 15:32 UTC (permalink / raw)
To: u-boot
Update the DWC2 USB driver to support a live tree.
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---
drivers/usb/host/dwc2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/dwc2.c b/drivers/usb/host/dwc2.c
index 64c42ac..0ed72d5 100644
--- a/drivers/usb/host/dwc2.c
+++ b/drivers/usb/host/dwc2.c
@@ -1245,7 +1245,7 @@ static int dwc2_usb_ofdata_to_platdata(struct udevice *dev)
struct dwc2_priv *priv = dev_get_priv(dev);
fdt_addr_t addr;
- addr = devfdt_get_addr(dev);
+ addr = dev_read_addr(dev);
if (addr == FDT_ADDR_T_NONE)
return -EINVAL;
priv->regs = (struct dwc2_core_regs *)addr;
--
2.1.4
^ permalink raw reply related [flat|nested] 23+ messages in thread* [U-Boot] [RESEND PATCH 5/6] usb: host: ehci-generic: convert to livetree
2017-09-12 15:32 [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7 Philipp Tomsich
` (3 preceding siblings ...)
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 4/6] usb: dwc2: convert to livetree Philipp Tomsich
@ 2017-09-12 15:32 ` Philipp Tomsich
2017-09-13 4:27 ` Simon Glass
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 6/6] rockchip: defconfig: puma-rk3399: enable OF_LIVE (live tree) Philipp Tomsich
2017-09-13 9:42 ` [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7 Marek Vasut
6 siblings, 1 reply; 23+ messages in thread
From: Philipp Tomsich @ 2017-09-12 15:32 UTC (permalink / raw)
To: u-boot
Update the generic EHCI driver to support a live tree.
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---
drivers/usb/host/ehci-generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-generic.c b/drivers/usb/host/ehci-generic.c
index 03f8d32..18e1e0e 100644
--- a/drivers/usb/host/ehci-generic.c
+++ b/drivers/usb/host/ehci-generic.c
@@ -108,7 +108,7 @@ static int ehci_usb_probe(struct udevice *dev)
}
}
- hccr = map_physmem(devfdt_get_addr(dev), 0x100, MAP_NOCACHE);
+ hccr = map_physmem(dev_read_addr(dev), 0x100, MAP_NOCACHE);
hcor = (struct ehci_hcor *)((uintptr_t)hccr +
HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
--
2.1.4
^ permalink raw reply related [flat|nested] 23+ messages in thread* [U-Boot] [RESEND PATCH 6/6] rockchip: defconfig: puma-rk3399: enable OF_LIVE (live tree)
2017-09-12 15:32 [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7 Philipp Tomsich
` (4 preceding siblings ...)
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 5/6] usb: host: ehci-generic: " Philipp Tomsich
@ 2017-09-12 15:32 ` Philipp Tomsich
2017-09-13 4:27 ` Simon Glass
2017-09-13 10:29 ` [U-Boot] [U-Boot, RESEND, " Philipp Tomsich
2017-09-13 9:42 ` [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7 Marek Vasut
6 siblings, 2 replies; 23+ messages in thread
From: Philipp Tomsich @ 2017-09-12 15:32 UTC (permalink / raw)
To: u-boot
With the critical drivers ready for switching to a live tree, we can
not enable it in the defconfig for the RK3399-Q7.
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---
configs/puma-rk3399_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/puma-rk3399_defconfig b/configs/puma-rk3399_defconfig
index 861b8c6..62a8d7c 100644
--- a/configs/puma-rk3399_defconfig
+++ b/configs/puma-rk3399_defconfig
@@ -38,6 +38,7 @@ CONFIG_CMD_TIME=y
CONFIG_CMD_PMIC=y
CONFIG_CMD_REGULATOR=y
CONFIG_SPL_OF_CONTROL=y
+CONFIG_OF_LIVE=y
CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
CONFIG_ENV_IS_IN_MMC=y
CONFIG_REGMAP=y
--
2.1.4
^ permalink raw reply related [flat|nested] 23+ messages in thread* [U-Boot] [RESEND PATCH 6/6] rockchip: defconfig: puma-rk3399: enable OF_LIVE (live tree)
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 6/6] rockchip: defconfig: puma-rk3399: enable OF_LIVE (live tree) Philipp Tomsich
@ 2017-09-13 4:27 ` Simon Glass
2017-09-13 10:29 ` [U-Boot] [U-Boot, RESEND, " Philipp Tomsich
1 sibling, 0 replies; 23+ messages in thread
From: Simon Glass @ 2017-09-13 4:27 UTC (permalink / raw)
To: u-boot
On 12 September 2017 at 09:32, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> With the critical drivers ready for switching to a live tree, we can
> not enable it in the defconfig for the RK3399-Q7.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>
> configs/puma-rk3399_defconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 23+ messages in thread
* [U-Boot] [U-Boot, RESEND, 6/6] rockchip: defconfig: puma-rk3399: enable OF_LIVE (live tree)
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 6/6] rockchip: defconfig: puma-rk3399: enable OF_LIVE (live tree) Philipp Tomsich
2017-09-13 4:27 ` Simon Glass
@ 2017-09-13 10:29 ` Philipp Tomsich
1 sibling, 0 replies; 23+ messages in thread
From: Philipp Tomsich @ 2017-09-13 10:29 UTC (permalink / raw)
To: u-boot
> With the critical drivers ready for switching to a live tree, we can
> not enable it in the defconfig for the RK3399-Q7.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>
> configs/puma-rk3399_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Applied to u-boot-rockchip, thanks!
^ permalink raw reply [flat|nested] 23+ messages in thread
* [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7
2017-09-12 15:32 [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7 Philipp Tomsich
` (5 preceding siblings ...)
2017-09-12 15:32 ` [U-Boot] [RESEND PATCH 6/6] rockchip: defconfig: puma-rk3399: enable OF_LIVE (live tree) Philipp Tomsich
@ 2017-09-13 9:42 ` Marek Vasut
2017-09-13 9:47 ` Dr. Philipp Tomsich
6 siblings, 1 reply; 23+ messages in thread
From: Marek Vasut @ 2017-09-13 9:42 UTC (permalink / raw)
To: u-boot
On 09/12/2017 05:32 PM, Philipp Tomsich wrote:
> This series repeats the same exercise as for the RK3368 and adapts any
> lingering dependencies necessary to move the RK3399-based boards over
> to use a live tree. Validated on the RK3399-Q7 (Puma).
>
> Resent, due to an apparent patchworks hick-up yesterday that "ate my series".
>
>
> Philipp Tomsich (6):
> rockchip: clk: rk3399: Convert to livetree
> rockchip: xhci: Convert to livetree
> rockchip: efuse: change to use dev_read_addr_ptr
> usb: dwc2: convert to livetree
> usb: host: ehci-generic: convert to livetree
> rockchip: defconfig: puma-rk3399: enable OF_LIVE (live tree)
So how are these patches dependent on one another ? They look like
mostly separate patches to me. I certainly cannot take the whole
patchset through -usb ...
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 23+ messages in thread* [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7
2017-09-13 9:42 ` [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7 Marek Vasut
@ 2017-09-13 9:47 ` Dr. Philipp Tomsich
2017-09-13 9:48 ` Dr. Philipp Tomsich
2017-09-13 9:49 ` Marek Vasut
0 siblings, 2 replies; 23+ messages in thread
From: Dr. Philipp Tomsich @ 2017-09-13 9:47 UTC (permalink / raw)
To: u-boot
> On 13 Sep 2017, at 11:42, Marek Vasut <marex@denx.de> wrote:
>
> On 09/12/2017 05:32 PM, Philipp Tomsich wrote:
>> This series repeats the same exercise as for the RK3368 and adapts any
>> lingering dependencies necessary to move the RK3399-based boards over
>> to use a live tree. Validated on the RK3399-Q7 (Puma).
>>
>> Resent, due to an apparent patchworks hick-up yesterday that "ate my series".
>>
>>
>> Philipp Tomsich (6):
>> rockchip: clk: rk3399: Convert to livetree
>> rockchip: xhci: Convert to livetree
>> rockchip: efuse: change to use dev_read_addr_ptr
>> usb: dwc2: convert to livetree
>> usb: host: ehci-generic: convert to livetree
>> rockchip: defconfig: puma-rk3399: enable OF_LIVE (live tree)
>
> So how are these patches dependent on one another ? They look like
> mostly separate patches to me. I certainly cannot take the whole
> patchset through -usb ...
These are all dependencies to move RK3399 boards to OF_LIVE.
We have two options:
(a) keep them together and I move them through u-boot-rockchip after
you send a review for the usb-related patches
(b) I split the series, but then the usb-related changes are left dangling
as there won’t be a clear indication how this was tested and what
context these came from.
Either approach is fine with me.
Regards,
Philipp.
^ permalink raw reply [flat|nested] 23+ messages in thread
* [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7
2017-09-13 9:47 ` Dr. Philipp Tomsich
@ 2017-09-13 9:48 ` Dr. Philipp Tomsich
2017-09-13 9:51 ` Marek Vasut
2017-09-13 9:49 ` Marek Vasut
1 sibling, 1 reply; 23+ messages in thread
From: Dr. Philipp Tomsich @ 2017-09-13 9:48 UTC (permalink / raw)
To: u-boot
> On 13 Sep 2017, at 11:47, Dr. Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote:
>
>
>> On 13 Sep 2017, at 11:42, Marek Vasut <marex@denx.de> wrote:
>>
>> On 09/12/2017 05:32 PM, Philipp Tomsich wrote:
>>> This series repeats the same exercise as for the RK3368 and adapts any
>>> lingering dependencies necessary to move the RK3399-based boards over
>>> to use a live tree. Validated on the RK3399-Q7 (Puma).
>>>
>>> Resent, due to an apparent patchworks hick-up yesterday that "ate my series".
>>>
>>>
>>> Philipp Tomsich (6):
>>> rockchip: clk: rk3399: Convert to livetree
>>> rockchip: xhci: Convert to livetree
>>> rockchip: efuse: change to use dev_read_addr_ptr
>>> usb: dwc2: convert to livetree
>>> usb: host: ehci-generic: convert to livetree
>>> rockchip: defconfig: puma-rk3399: enable OF_LIVE (live tree)
>>
>> So how are these patches dependent on one another ? They look like
>> mostly separate patches to me. I certainly cannot take the whole
>> patchset through -usb ...
>
> These are all dependencies to move RK3399 boards to OF_LIVE.
>
> We have two options:
> (a) keep them together and I move them through u-boot-rockchip after
> you send a review for the usb-related patches
> (b) I split the series, but then the usb-related changes are left dangling
> as there won’t be a clear indication how this was tested and what
> context these came from.
>
> Either approach is fine with me.
I just realised that the entire series has been delegated to me in Patchwork
anyway, so it seems as if option (a) would be the “default choice” …
Regards,
Philipp.
^ permalink raw reply [flat|nested] 23+ messages in thread
* [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7
2017-09-13 9:48 ` Dr. Philipp Tomsich
@ 2017-09-13 9:51 ` Marek Vasut
0 siblings, 0 replies; 23+ messages in thread
From: Marek Vasut @ 2017-09-13 9:51 UTC (permalink / raw)
To: u-boot
On 09/13/2017 11:48 AM, Dr. Philipp Tomsich wrote:
>
>> On 13 Sep 2017, at 11:47, Dr. Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote:
>>
>>
>>> On 13 Sep 2017, at 11:42, Marek Vasut <marex@denx.de> wrote:
>>>
>>> On 09/12/2017 05:32 PM, Philipp Tomsich wrote:
>>>> This series repeats the same exercise as for the RK3368 and adapts any
>>>> lingering dependencies necessary to move the RK3399-based boards over
>>>> to use a live tree. Validated on the RK3399-Q7 (Puma).
>>>>
>>>> Resent, due to an apparent patchworks hick-up yesterday that "ate my series".
>>>>
>>>>
>>>> Philipp Tomsich (6):
>>>> rockchip: clk: rk3399: Convert to livetree
>>>> rockchip: xhci: Convert to livetree
>>>> rockchip: efuse: change to use dev_read_addr_ptr
>>>> usb: dwc2: convert to livetree
>>>> usb: host: ehci-generic: convert to livetree
>>>> rockchip: defconfig: puma-rk3399: enable OF_LIVE (live tree)
>>>
>>> So how are these patches dependent on one another ? They look like
>>> mostly separate patches to me. I certainly cannot take the whole
>>> patchset through -usb ...
>>
>> These are all dependencies to move RK3399 boards to OF_LIVE.
>>
>> We have two options:
>> (a) keep them together and I move them through u-boot-rockchip after
>> you send a review for the usb-related patches
>> (b) I split the series, but then the usb-related changes are left dangling
>> as there won’t be a clear indication how this was tested and what
>> context these came from.
>>
>> Either approach is fine with me.
>
> I just realised that the entire series has been delegated to me in Patchwork
> anyway, so it seems as if option (a) would be the “default choice” …
And if SoC trees decide to pull in subsystem stuff, then subsystem
maintainers will go nuts from dealing with changes in their area which
is out of their control, there will be merge conflicts all over the
place etc .. excellent.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 23+ messages in thread
* [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7
2017-09-13 9:47 ` Dr. Philipp Tomsich
2017-09-13 9:48 ` Dr. Philipp Tomsich
@ 2017-09-13 9:49 ` Marek Vasut
2017-09-13 9:53 ` Dr. Philipp Tomsich
1 sibling, 1 reply; 23+ messages in thread
From: Marek Vasut @ 2017-09-13 9:49 UTC (permalink / raw)
To: u-boot
On 09/13/2017 11:47 AM, Dr. Philipp Tomsich wrote:
>
>> On 13 Sep 2017, at 11:42, Marek Vasut <marex@denx.de> wrote:
>>
>> On 09/12/2017 05:32 PM, Philipp Tomsich wrote:
>>> This series repeats the same exercise as for the RK3368 and adapts any
>>> lingering dependencies necessary to move the RK3399-based boards over
>>> to use a live tree. Validated on the RK3399-Q7 (Puma).
>>>
>>> Resent, due to an apparent patchworks hick-up yesterday that "ate my series".
>>>
>>>
>>> Philipp Tomsich (6):
>>> rockchip: clk: rk3399: Convert to livetree
>>> rockchip: xhci: Convert to livetree
>>> rockchip: efuse: change to use dev_read_addr_ptr
>>> usb: dwc2: convert to livetree
>>> usb: host: ehci-generic: convert to livetree
>>> rockchip: defconfig: puma-rk3399: enable OF_LIVE (live tree)
>>
>> So how are these patches dependent on one another ? They look like
>> mostly separate patches to me. I certainly cannot take the whole
>> patchset through -usb ...
>
> These are all dependencies to move RK3399 boards to OF_LIVE.
>
> We have two options:
> (a) keep them together and I move them through u-boot-rockchip after
> you send a review for the usb-related patches
> (b) I split the series, but then the usb-related changes are left dangling
> as there won’t be a clear indication how this was tested and what
> context these came from.
>
> Either approach is fine with me.
Since some of this is core USB stuff, it should go through -usb , that's
what the subsystem trees are for. I also don't see any problem with
pulling the USB ones in separately, they do not seem to depend on
anything else in that series.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 23+ messages in thread
* [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7
2017-09-13 9:49 ` Marek Vasut
@ 2017-09-13 9:53 ` Dr. Philipp Tomsich
2017-09-13 9:56 ` Marek Vasut
0 siblings, 1 reply; 23+ messages in thread
From: Dr. Philipp Tomsich @ 2017-09-13 9:53 UTC (permalink / raw)
To: u-boot
> On 13 Sep 2017, at 11:49, Marek Vasut <marex@denx.de> wrote:
>
> On 09/13/2017 11:47 AM, Dr. Philipp Tomsich wrote:
>>
>>> On 13 Sep 2017, at 11:42, Marek Vasut <marex@denx.de> wrote:
>>>
>>> On 09/12/2017 05:32 PM, Philipp Tomsich wrote:
>>>> This series repeats the same exercise as for the RK3368 and adapts any
>>>> lingering dependencies necessary to move the RK3399-based boards over
>>>> to use a live tree. Validated on the RK3399-Q7 (Puma).
>>>>
>>>> Resent, due to an apparent patchworks hick-up yesterday that "ate my series".
>>>>
>>>>
>>>> Philipp Tomsich (6):
>>>> rockchip: clk: rk3399: Convert to livetree
>>>> rockchip: xhci: Convert to livetree
>>>> rockchip: efuse: change to use dev_read_addr_ptr
>>>> usb: dwc2: convert to livetree
>>>> usb: host: ehci-generic: convert to livetree
>>>> rockchip: defconfig: puma-rk3399: enable OF_LIVE (live tree)
>>>
>>> So how are these patches dependent on one another ? They look like
>>> mostly separate patches to me. I certainly cannot take the whole
>>> patchset through -usb ...
>>
>> These are all dependencies to move RK3399 boards to OF_LIVE.
>>
>> We have two options:
>> (a) keep them together and I move them through u-boot-rockchip after
>> you send a review for the usb-related patches
>> (b) I split the series, but then the usb-related changes are left dangling
>> as there won’t be a clear indication how this was tested and what
>> context these came from.
>>
>> Either approach is fine with me.
>
> Since some of this is core USB stuff, it should go through -usb , that's
> what the subsystem trees are for. I also don't see any problem with
> pulling the USB ones in separately, they do not seem to depend on
> anything else in that series.
Just ACK those that you’ll take and I’ll try not to step on your toes when
handling the remainder of the series.
Regards,
Philipp.
^ permalink raw reply [flat|nested] 23+ messages in thread
* [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7
2017-09-13 9:53 ` Dr. Philipp Tomsich
@ 2017-09-13 9:56 ` Marek Vasut
0 siblings, 0 replies; 23+ messages in thread
From: Marek Vasut @ 2017-09-13 9:56 UTC (permalink / raw)
To: u-boot
On 09/13/2017 11:53 AM, Dr. Philipp Tomsich wrote:
>
>> On 13 Sep 2017, at 11:49, Marek Vasut <marex@denx.de> wrote:
>>
>> On 09/13/2017 11:47 AM, Dr. Philipp Tomsich wrote:
>>>
>>>> On 13 Sep 2017, at 11:42, Marek Vasut <marex@denx.de> wrote:
>>>>
>>>> On 09/12/2017 05:32 PM, Philipp Tomsich wrote:
>>>>> This series repeats the same exercise as for the RK3368 and adapts any
>>>>> lingering dependencies necessary to move the RK3399-based boards over
>>>>> to use a live tree. Validated on the RK3399-Q7 (Puma).
>>>>>
>>>>> Resent, due to an apparent patchworks hick-up yesterday that "ate my series".
>>>>>
>>>>>
>>>>> Philipp Tomsich (6):
>>>>> rockchip: clk: rk3399: Convert to livetree
>>>>> rockchip: xhci: Convert to livetree
>>>>> rockchip: efuse: change to use dev_read_addr_ptr
>>>>> usb: dwc2: convert to livetree
>>>>> usb: host: ehci-generic: convert to livetree
>>>>> rockchip: defconfig: puma-rk3399: enable OF_LIVE (live tree)
>>>>
>>>> So how are these patches dependent on one another ? They look like
>>>> mostly separate patches to me. I certainly cannot take the whole
>>>> patchset through -usb ...
>>>
>>> These are all dependencies to move RK3399 boards to OF_LIVE.
>>>
>>> We have two options:
>>> (a) keep them together and I move them through u-boot-rockchip after
>>> you send a review for the usb-related patches
>>> (b) I split the series, but then the usb-related changes are left dangling
>>> as there won’t be a clear indication how this was tested and what
>>> context these came from.
>>>
>>> Either approach is fine with me.
>>
>> Since some of this is core USB stuff, it should go through -usb , that's
>> what the subsystem trees are for. I also don't see any problem with
>> pulling the USB ones in separately, they do not seem to depend on
>> anything else in that series.
>
> Just ACK those that you’ll take and I’ll try not to step on your toes when
> handling the remainder of the series.
I applied 2,4,5 to -usb , next time try to split the series please.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 23+ messages in thread