public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tor Krill <tor@excito.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Problem with flash cfi legacy mode
Date: Mon, 17 Mar 2008 07:58:42 +0000 (UTC)	[thread overview]
Message-ID: <NyLtDrlT.1205740722.4117870.tor@localhost> (raw)
In-Reply-To: <47DAF397.6050702@discworld.dascon.de>




On 3/14/2008, "Michael Schwingen" <rincewind@discworld.dascon.de> wrote:

>Tor Krill wrote:
>> Im working on adding support for our board to u-boot.
>>
>> I use legacy flash mode for our boot-flash. I however have some problems
>> with it.
>>
>> When using jedec probe to identify our flash. Im unable to do so with our
>> 16bit device-id. In my opinion it seems like this actually wont work(?)
>>
>> cmdset_amd_read_jedec_ids uses _one_ flash_read_uchar call to read out
>> the device id(, if its not an amd extended one). The only way i could
>> get this to work with our flash was to only put the lower 8bit in the
>> dev_id field when adding an entry to the jedec_table.
>>
>Hm - right. You are probably the first one to use that code on a 16-bit
>non-CFI flash - for 16-bit flashs, the read will need to be changed, but
>I am not sure how exactly - I think we may need separate code depending
>on info->chipwidth, because 8-bit flashs only have an 8-bit ID.

Can one asume that a chip with chipwidht 16 always has an ID of 16bit?
And how does AMD expanded 3byte id mode fit?  If its safe to just change
the read   it should be trivial to fix(?)

>> Further on it seems like CFI_CMDSET_AMD_LEGACY is unsupported in
>> flash_write_cfibuffer.
>>
>Right. Setting info->buffer_size = 1 in jedec_flash.c/fill_info() should
>make sure that part of code is never executed.

Ok, i just skipped CFG_FLASH_USE_BUFFER_WRITE instead. That solved it for
me.

/Tor

  reply	other threads:[~2008-03-17  7:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-10  9:19 [U-Boot-Users] Problem with flash cfi legacy mode Tor Krill
2008-03-14 21:52 ` Michael Schwingen
2008-03-17  7:58   ` Tor Krill [this message]
2008-03-21 23:11     ` Michael Schwingen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=NyLtDrlT.1205740722.4117870.tor@localhost \
    --to=tor@excito.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox