Re: [PATCH 0/2] odroid: fix boot issues on u2, xu4 and siblings

Joost van Zwieten
2023-02-08T23:03:43Z

On Wed, Feb 8, 2023 at 20:04, Henrik Grimler <henrik@grimler.se> wrote:
> Hi,

Hi Henrik,

Thanks for picking this up.

> Patch 1 fixes issue reported in [1], which happens on odroid-u2 and
> probably other devices in that family. Re-adding this quirk was
> discussed already by Jaehoon and Andy in the patch that
> (re-)introduced this issue [2], but I do not think a patch was sent
> for it.
>
> Patch 2 fixes issue reported in [3], which happens on odroid-{u2,xu4}
> and other devices in that family. An alternative fix was sent
> previously by Joost [4], but has not been picked up yet.

Patch 2 is anyhow a better fix than [4].

> Tested on odroid-u2 and odroid-xu4 on top of master branch, I am able
> to boot from sdcard on both without issues.

I can confirm that the patches work for me as well - not a surprise as
we have the same board.

Best, Joost

> [1] https://lists.denx.de/pipermail/u-boot/2023-January/504116.html
> [2] https://lists.denx.de/pipermail/u-boot/2021-March/445243.html
> [3] https://lists.denx.de/pipermail/u-boot/2023-January/504115.html
> [4] https://lists.denx.de/pipermail/u-boot/2023-January/505551.html
>
>
> Henrik Grimler (2):
> Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B"
> samsung: common: only load CROS_EC if enabled in config
>
> board/samsung/common/board.c | 27 ++++++++++++++-------------
> drivers/mmc/s5p_sdhci.c | 2 +-
> 2 files changed, 15 insertions(+), 14 deletions(-)
>
> --
> 2.30.2