From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Date: Tue, 29 Dec 2020 00:03:57 +0200
Subject: [PATCH 3/6] efi_loader: Replace config option with EFI variable
 for initrd loading
In-Reply-To: <2d1353b0-da10-d112-63ac-89418eae1bbe@gmx.de>
References: <20201228122440.316403-1-ilias.apalodimas@linaro.org>
 <20201228122440.316403-4-ilias.apalodimas@linaro.org>
 <2d1353b0-da10-d112-63ac-89418eae1bbe@gmx.de>
Message-ID: <X+pWTQ0lJEiFbv4n@enceladus>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Heinrich, 

On Mon, Dec 28, 2020 at 03:55:49PM +0100, Heinrich Schuchardt wrote:
[...]
> >   		ret = try_load_entry(bootorder[i], handle, load_options);
> > -		if (ret == EFI_SUCCESS)
> > +		if (ret == EFI_SUCCESS) {
> > +			if (IS_ENABLED(CONFIG_EFI_LOAD_FILE2_INITRD))
> > +				ret = efi_initrd_register();
> 
> I think this is not enough.
> 
> * We should uninstall the protocol once 'bootefi bootmgr' returns
>   to U-Boot.
> * The EFI_LOAD_FILE2_PROTOCOL should be installed on the handle of
>   the loaded image for this purpose.
> 

Yep you are right. I completely missed that case, I'll fix it on v2

Regards
/Ilias