From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54DBBC05027 for ; Mon, 20 Feb 2023 16:06:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3EC9985194; Mon, 20 Feb 2023 17:06:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="SFUkRamT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8229A8537E; Mon, 20 Feb 2023 17:05:58 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1498F80F72 for ; Mon, 20 Feb 2023 17:05:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id ay9so1028482qtb.9 for ; Mon, 20 Feb 2023 08:05:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4t3ri0atOnEJLzVByPggHO4K64nY3HlKOjLmuYIHpgA=; b=SFUkRamTqJ6exxVBz2z3UuaXJUni4jldnWOVutdhzAPJwPPojrkN5+t6rdfZxuQkwF MwVFlblRCSq3WCn1YEeC6Vs5ShqDOPG+8r40jGXku5RDbNi5WlIFwwlT/aT1D51dFMZd KKfrSPEGV5zSjuByv58YUclflhrZk2+0SAqfk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4t3ri0atOnEJLzVByPggHO4K64nY3HlKOjLmuYIHpgA=; b=goqm3dnmQgKi3IuxBm+KQLDgN7SECdEUsqvNMEgUiDl72Z1wZ0SJ7XyQIJATa1mp9S bdBjDRv1jM61cf56jtDiNnl0BaGAxvsNPpROnPduGFddymmDJSfHdewClMEAIA81QnJL lGBMF/KWkUw4dlK8dAE1de897FOlhTKI02NETjsfkHeajTwrw8sZ56bkrjsRIkFVV8hX kPQh8p95EDp/0Jkc14+9h7oiObQwMgwu/Cwyns0NJ5h+1j+nHXow2ETEAUIGZvnClsZs u6h8yLmr/9XIBzuDMDUgH+eeSMfNxuwi00oCdcz8It4jonLSTFR+W/yJ4mLBQy667/gy yCaw== X-Gm-Message-State: AO0yUKVdBLckfJEyRKFimWYtUkU6cBweykO4fJfaKcm3XBmpkyO45MAi QK9yARr/yxKtEd6+ku9uNxiQHw== X-Google-Smtp-Source: AK7set9vCDNVTgpJR7z8SiDyBDnqwaLHsE59qSK2y6IfsBHS5kupKDUQZiMuVIo3NcLHp+Ua8wO9fw== X-Received: by 2002:ac8:57c2:0:b0:3ac:fba0:cde with SMTP id w2-20020ac857c2000000b003acfba00cdemr19286260qta.22.1676909153899; Mon, 20 Feb 2023 08:05:53 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-8f08-76c2-2eb2-d6bf.res6.spectrum.com. [2603:6081:7b00:6400:8f08:76c2:2eb2:d6bf]) by smtp.gmail.com with ESMTPSA id g9-20020ac84b69000000b003b9bb59543fsm9014934qts.61.2023.02.20.08.05.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 08:05:53 -0800 (PST) Date: Mon, 20 Feb 2023 11:05:51 -0500 From: Tom Rini To: Adam Ford Cc: u-boot@lists.denx.de, aford@beaconembedded.com, Stefano Babic , Fabio Estevam , "NXP i.MX U-Boot Team" Subject: Re: [PATCH V3] arm64: imx: Add support for imx8mp-beacon-kit Message-ID: References: <20230220155058.675908-1-aford173@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0eK1RVhzaFF7Ca06" Content-Disposition: inline In-Reply-To: <20230220155058.675908-1-aford173@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --0eK1RVhzaFF7Ca06 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 20, 2023 at 09:50:58AM -0600, Adam Ford wrote: > Beacon Embedded has an i.MX8M Plus development kit which consists > of a SOM + baseboard. The SOM includes Bluetooth, WiFi, QSPI, eMMC, > and one Ethernet PHY. The baseboard includes audio, HDMI, USB-C Dual > Role port, USB Hub with five ports, a PCIe slot, and a second Ethernet > PHY. The device trees are already queued for inclusion in Linux 6.3. >=20 > Signed-off-by: Adam Ford In general, Reviewed-by: Tom Rini And if there's no other feedback, a follow-up patch is fine as this is likely something to look at on your other platforms too, as further clean-up work: > diff --git a/board/beacon/imx8mp/imx8mp_beacon.c b/board/beacon/imx8mp/im= x8mp_beacon.c > new file mode 100644 > index 0000000000..d07d8aa421 > --- /dev/null > +++ b/board/beacon/imx8mp/imx8mp_beacon.c > @@ -0,0 +1,63 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* Copyright 2023 Logic PD, Inc dba Beacon EmbeddedWorks */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include For a small code file, this is a long include list, do we need everything here, still? > +DECLARE_GLOBAL_DATA_PTR; And I don't see anything referring to gd, so I don't think we need this. > diff --git a/board/beacon/imx8mp/spl.c b/board/beacon/imx8mp/spl.c > new file mode 100644 > index 0000000000..591e8ca9ab > --- /dev/null > +++ b/board/beacon/imx8mp/spl.c > @@ -0,0 +1,132 @@ Same as the above, here. --=20 Tom --0eK1RVhzaFF7Ca06 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPzmlUACgkQFHw5/5Y0 tywpNgwAubK0fas4rbtufVMXP0o4ssvBLPVAd7VtJisdpsgrveSmUGV6gHRh41jC vvtKY7Mgc1lQvLsPdiQb8v51oZ0p6G9IV+4ichdz95uhZilT9wJRLPJ2C6oBH1gG MD8FuV+porEVv2zy+sBRB5WYuhLFr5QWYkAEvbBCgtJq12xHaQm8HzYklrwE2ob7 LzrDcHcadu4xiTyOkilXgpwYLdgU/mMIs1hMyzuQCSp7KVtZ9aKN9Ltv5uYAcoWu eHF9mr7vszhX17EKJeeSDpdJ/aXIIeVmdM6KT1L5ho+YgnP5L+SB/yIZTZNezNma Bw8+rwbkQRKxSxJEEf9+jTjtkt3iDyNxnAef00Bflhn980mbsIQ+c7g/vnXW1mG/ BfhwEoxRdt0nkOXCpy92FeiVRlp9+WHJG/yGiPdnqmHZ091hTZJ0HXRaazfhdSgY Sq9WRLYGPC4QtxLUHFSPlyfH8uTY6qGfTd/ZH16Hu7wu1A30n60QNWKEfJIQDghP UEi6HGsA =ahdh -----END PGP SIGNATURE----- --0eK1RVhzaFF7Ca06--